Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Avoid building wheels on unrelated releases, split pypi tokens #523

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

aborgna-q
Copy link
Collaborator

  • Stops the wheel building jobs from running on releases of other packages.
    Adding a release for tket2-eccs caused tket2 wheels to be built. Since that's an expensive workflow, this filters it out.
    We continue to build for all platforms on each commit to main. We may want to skip some platforms in the future.

  • Splits the pypi token used for publishing tket2-py and tket2-eccs.
    Scoped tokens only give permissions to a single project. Splitting the tokens here will let us replace the currently unrestricted token.

@aborgna-q aborgna-q requested a review from a team as a code owner August 2, 2024 10:10
@aborgna-q aborgna-q requested a review from lmondada August 2, 2024 10:10
Copy link
Contributor

@lmondada lmondada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Agustin!

@aborgna-q aborgna-q added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 3266d2f Aug 2, 2024
29 checks passed
@aborgna-q aborgna-q deleted the ab/skip-more-wheel-builds branch August 2, 2024 10:17
github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2024
Fix #523 not actually running the pure wheel building steps...
Now that that got merged to main I was able to _workflow dispatch_ it to
test, and it seems I used the wrong syntax for the ifs.

It works now:
https://github.com/CQCL/tket2/actions/runs/10214055732/job/28260696536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants