Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(py): Specify py dependencies for packaged wheels #477

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jul 12, 2024

Fixes #476

This is an annoying duplication due to poetry not following PEP 631 and reading dependencies from [project.dependencies].

BEGIN_COMMIT_OVERRIDE
fix(py): Specify py dependencies for packaged wheels

Release-As: 0.1.0a3
END_COMMIT_OVERRIDE

@aborgna-q aborgna-q requested a review from a team as a code owner July 12, 2024 13:53
@aborgna-q aborgna-q requested a review from doug-q July 12, 2024 13:53
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (62da091) to head (3ad7c89).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #477       +/-   ##
===========================================
+ Coverage   81.94%   96.73%   +14.79%     
===========================================
  Files          61       17       -44     
  Lines        6071      521     -5550     
  Branches     5550        0     -5550     
===========================================
- Hits         4975      504     -4471     
+ Misses        835       17      -818     
+ Partials      261        0      -261     
Flag Coverage Δ
python 96.73% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@aborgna-q aborgna-q added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit f0529b4 Jul 12, 2024
14 checks passed
@aborgna-q aborgna-q deleted the ab/fix-missing-deps-in-wheels branch July 12, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies not included in package
2 participants