Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Restructure the python code #211

Merged
merged 16 commits into from
Nov 3, 2023
Merged

refactor: Restructure the python code #211

merged 16 commits into from
Nov 3, 2023

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Nov 2, 2023

@aborgna-q aborgna-q requested a review from ss2165 November 2, 2023 16:00
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #211 (0e8aba8) into main (dc03c31) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   75.26%   74.98%   -0.28%     
==========================================
  Files          35       30       -5     
  Lines        4115     4018      -97     
  Branches     4018     4018              
==========================================
- Hits         3097     3013      -84     
+ Misses        838      825      -13     
  Partials      180      180              
Files Coverage Δ
tket2/src/json.rs 42.42% <0.00%> (ø)
tket2/src/passes/commutation.rs 74.15% <0.00%> (ø)
tket2/src/portmatching/pattern.rs 89.30% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aborgna-q aborgna-q changed the title refactor: Restructure the rust and python code refactor: Restructure the python code Nov 2, 2023
@aborgna-q aborgna-q force-pushed the refactor/restructure branch from 8eae2ce to fea1b42 Compare November 2, 2023 17:01
@aborgna-q aborgna-q force-pushed the refactor/restructure branch from fea1b42 to ce95602 Compare November 2, 2023 17:10
@aborgna-q aborgna-q force-pushed the refactor/restructure branch from 8d9d556 to d9a96fc Compare November 3, 2023 10:42
Base automatically changed from refactor/restructure-core to main November 3, 2023 14:21
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Cargo.toml Outdated
@@ -23,3 +23,6 @@ pyo3 = { version = "0.20" }
itertools = { version = "0.11.0" }
tket-json-rs = "0.2.0"
tracing = "0.1.37"
portmatching = { git = "https://github.com/lmondada/portmatching", rev = "738c91c", features = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unrelated?

pyproject.toml Outdated
packages = [{ include = "tket2-py" }]

[tool.poetry.dependencies]
python = "^3.10,<3.12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 3.12?

@aborgna-q aborgna-q added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 4fe9e38 Nov 3, 2023
10 of 11 checks passed
@aborgna-q aborgna-q deleted the refactor/restructure branch November 3, 2023 14:55
github-merge-queue bot pushed a commit that referenced this pull request Nov 10, 2023
#211 didn't update the coverage path in `ci.yml` x_x
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
## 🤖 New release
* `tket2`: 0.1.0-alpha.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.0.0-alpha.1](https://github.com/CQCL/tket2/releases/tag/tket2-v0.0.0-alpha.1)
- 2024-05-24

### Bug Fixes
- Check for rewrite composition in badger
([#255](#255))
- induced cycles in depth optimisation
([#264](#264))
- Encode opaque symbolic constants
([#273](#273))
- Correctly detect custom ops by name
([#281](#281))
- Track input linear units in `Command`
([#310](#310))
- Don't convert tket2 measurements into tket1 ops
([#331](#331))

### Documentation
- Expand the main module and README docs
([#298](#298))

### New Features
- add angle type to tket2 extension
([#231](#231))
- bindings for circuit cost and hash
([#252](#252))
- Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
- Add a "progress timeout" to badger
([#259](#259))
- [**breaking**] Add lexicographic cost
([#270](#270))
- rewrite tracing ([#267](#267))
- Move pre/post rewrite cost to the RewriteStrategy API
([#276](#276))
- [**breaking**] Lexicographic cost fn
([#277](#277))
- Return rewrite strategies as a generator
([#275](#275))
- add qalloc, qfree, reset ops
([#284](#284))
- [**breaking**] Support any ops in portmatching
([#293](#293))
- Add `PatternMatch::nodes` and `subcircuit` + matching example
([#299](#299))
- Use `IncomingPort` and `OutgoingPort` instead of `Port` where
possible. ([#296](#296))
- expose Tk2Op name ([#307](#307))

### Refactor
- Move tket2 code to a workspace member
([#210](#210))
- Restructure the python code
([#211](#211))
- s/taso/badger/ ([#228](#228))
- Move python bindings from `tket2` to `tket2-py`
([#235](#235))
- rename t2op ([#256](#256))

### Testing
- Add small parallel badger test
([#237](#237))
- fix non-deterministic badger test
([#245](#245))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Agustin Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing rust python binding requires duplicated module names. Rename pyrs
2 participants