fix: Register the type parameters as custom types #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
approved these changes
Sep 13, 2023
|
Perhaps it's not the clearest API :P |
|
I'll merge this now so we can get the Hugr update working. We can change it later if there's a better way to define things. |
|
Yes, this looks right to me @aborgna-q @lmondada. API suggestions are welcome, but the essence is that you can't just create CustomType's that refer to meaningless names - you have to declare those names as TypeDef's in the Extension so that we can find the definition referred to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the errors found in #98 by registering the opaque
TypeParams as custom types in the extensions.@acl-cqc Is this the intended way to register parameters? There are no uses of
TypeParam::Opaquein Hugr to base this on.