Rewrite to_halfturns with unsafe (infallible) op
#630
Assignees
Comments
1 task
aborgna-q
changed the title
to_halfturns with unsafe (infallible) opto_halfturns with unsafe (infallible) op
|
We should add |
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 8, 2024
This is an operation that we are able to process while encoding pytket circuits. We expect guppy to emit this instead of adding explicit panics to unwrap the fallible result. The pytket encoder should now support float wires. Closes #630 I'll open a followup issue on guppy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This may be required to extract pytket circuits from hugrs with float/rotation parameter manipulation.
We should be able to match on the
to_halfturnsop followed by a conditional to unwrap or panic emitted by guppy.The general case is harder, as it may require type changing rewrites (as the
Option<float>may be passed around).The alternative to this is to track
option<float>as parameters in the pytket encoder, and have a constant folding that interprets panics as undefined behaviour (so the failing branch can be ignored).The text was updated successfully, but these errors were encountered: