Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crate::serialize::guppy needs to be updated for Packages #621

Closed
doug-q opened this issue Sep 27, 2024 · 1 comment · Fixed by #622
Closed

crate::serialize::guppy needs to be updated for Packages #621

doug-q opened this issue Sep 27, 2024 · 1 comment · Fixed by #622
Assignees
@aborgna-q

Comments

@doug-q
Copy link
Contributor

doug-q commented Sep 27, 2024

No description provided.

@doug-q
Copy link
Contributor Author

doug-q commented Sep 27, 2024

Also, no reason to not make find_function public: sometimes you already have a Hugr, the current interface requires you to serialise it!

@aborgna-q aborgna-q self-assigned this Sep 27, 2024
@aborgna-q aborgna-q mentioned this issue Sep 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
@aborgna-q
fix: Support hugr packages, fix the notebooks (#622)
1cf9dcb 
This is a small bundle of changes aimed at fixing the example notebooks.

- Use packages when building hugrs. This includes parsing guppy packages
from rust, as well as returning packages from the circuit builder.
  - This required adding exports for the tket2 extensions from python.
- We temporarily add a py dependency on `hugr-cli`, since packages are
currently defined there. See CQCL/hugr#1530
  
The `guppy -> pytket` pipeline is still broken, as guppy now generates
many more function calls and nested control flow primitives, which we do
not currently support.

drive-by: Make `crate::serialize::guppy::find_function` public.

Closes #621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Support hugr packages, fix the notebooks CQCL/tket2
2 participants
@aborgna-q @doug-q