Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take the default nam_6_3.rwr ecc set out of the python package #486

Closed
aborgna-q opened this issue Jul 15, 2024 · 0 comments · Fixed by #517
Closed

Take the default nam_6_3.rwr ecc set out of the python package #486

aborgna-q opened this issue Jul 15, 2024 · 0 comments · Fixed by #517
Assignees
Milestone

Comments

@aborgna-q
Copy link
Collaborator

We include the default rewrite set on each wheel, and that ends up bloating the storage used by each release on pypi.

An alternative would be to create a separate pure-python package, and include it as a dependency.

@aborgna-q aborgna-q added this to the 0.1.0 milestone Jul 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
Closes #486. We should merge this before publishing the next alpha.

I checked that the [generated
wheels](https://github.com/CQCL/tket2/actions/runs/10166482192/job/28116748310)
for `tket2-py` contain the correct (non-local) dependency on
`tket2_eccs`.

The pure-python wheels ci job is copied from
[`hugr-py`](https://github.com/CQCL/hugr/blob/dd1dc484447cc2180058f4474594ddb51fa45cd6/.github/workflows/python-wheels.yml).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant