add documentation of single qubit problem #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-cqc
reviewed
Mar 7, 2022
pytket/binders/mapping.cpp
Outdated
Comment on lines
109
to
111
| "This method is not labelling qubits that only have single qubits gates " | ||
| "or not gates at all on them. To get them labelled as well this method " | ||
| "can be used after applying a placer first.") |
There was a problem hiding this comment.
Can we simply say that this method only labels interacting qubits?
cqc-alec
reviewed
Mar 8, 2022
Co-authored-by: Alec Edgington <[email protected]>
yao-cqc
approved these changes
Mar 8, 2022
cqc-melf
added a commit
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yao-cqc ,
Could you please take a look on this changes to the documentation and let me know if you understand what the issue is on this point and if it is clear how to avoid it?