[TKET-1847] Update workflows for tket v2 #265

cqc-melf · 2022-03-01T17:29:52Z

adding changes to the workflows for routing v2

cqc-melf · 2022-03-01T17:30:41Z

Happy to have a discussion about my changes, please message me in case of any questions.

.github/workflows/build_and_test_v2.yml

.github/workflows/create_pr_v2.yml

.github/workflows/docs_v2.yml

.github/workflows/release_v2.yml

Co-authored-by: Alec Edgington <[email protected]>

…e-workflows-v2

cqc-melf · 2022-03-02T15:10:25Z

I have added the changes from #269 to the new workflows in the commit 0408239

cqc-alec · 2022-03-02T15:21:21Z

Should we add the valgrind check for PRs to develop2 as well?

…e-workflows-v2

cqc-melf · 2022-03-02T16:14:04Z

Should we add the valgrind check for PRs to develop2 as well?

Good point, from my understanding this could be done by adding develop2 to the workflow?

I have added that in @cqc-melf
add valgrind for develop2
6215eaf

cqc-alec · 2022-03-02T16:18:28Z

I think you made a mistake with the merge? This commit looks unintended.
The valgrind fix is good for now, but I imagine when the branches diverge they will want different workflows.

cqc-melf · 2022-03-02T16:22:31Z

I think you made a mistake with the merge? This commit looks unintended. The valgrind fix is good for now, but I imagine when the branches diverge they will want different workflows.

Oh yes, thank you. Do you want me to split the valgrind workflow now?

cqc-alec · 2022-03-02T16:24:42Z

Oh yes, thank you. Do you want me to split the valgrind workflow now?

No it's fine.

cqc-alec · 2022-03-02T16:26:19Z

linuxbuildwheel has become non-executable.

cqc-alec

Please make linuxbuildwheel executable again, otherwise LGTM.

cqc-alec · 2022-03-02T16:35:45Z

.github/workflows/build_and_test_v2.yml

+  schedule:
+    # 03:00 every Saturday morning
+    - cron: '0 3 * * 6'


Actually, we don't want this. This will just run it on the default branch (develop) -- which is already happening. Is there a way to run the schedule on a non-default branch?

cqc-alec · 2022-03-02T16:37:41Z

.github/workflows/valgrind.yml

  schedule:
    # 03:00 every Monday morning
    - cron: '0 3 * * 1'


Similarly here. This means I think that we do need a separate workflow for this.

It looks like that is possible, I will try to do that.

cqc-melf · 2022-03-02T17:35:20Z

@cqc-alec I have found a solution which require to duplicate all the workflows to make it work. I think that is fine because we will split that up soon anyway?

cqc-alec · 2022-03-03T10:38:04Z

.github/workflows/valgrind_v2_nightly.yml

+    - cron: '0 3 * * 1'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}


Does github.workflow evaluate to the name of the yml file (valgrind_v2_nightly) or the name of the workflow (valgrind check nightly)? If the latter it needs to be changed so that it is unique.

valgrind check nightly already was unique, but I have changed that for clarity.

cqc-alec · 2022-03-03T10:38:35Z

.github/workflows/valgrind.yml

@@ -3,6 +3,7 @@ on:
  pull_request:
    branches:
      - develop
+      - develop2


Having add the new one this should not be added here.

Still there?

Forgot to push the commit, sorry. It is up now in @cqc-melf
remove develop2 from valgrind check
84ca79c

cqc-alec · 2022-03-03T10:40:08Z

.github/workflows/build_and_test_v2_nightly.yml

+    - uses: actions/checkout@v2
+      with:
+        fetch-depth: '0'
+        ref: develop2    - run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*


This looks broken.

cqc-alec · 2022-03-03T10:46:48Z

.github/workflows/build_and_test_v2_nightly.yml

@@ -0,0 +1,436 @@
+name: Build and test v2 nightly


Do we really need a new file for this? Why can't we just put the ref: develop2 into the original file to make sure it runs on the right branch?
Same goes for the valgrind workflow.

From my understanding it is necessary to do it like this. If we change the branch in the PR workflow every check run on a PR would only evaluate the current state of develop2? Or have I misunderstood what you mean?

The only option I see is to integrate the valgrind_v2 into the valgrind check, but that probably need to be changes in the very near future anyway.

Ah yeah you're right.
It's really painful having so much boilerplate repeated in different workflows. We should look at using https://docs.github.com/en/actions/using-workflows/reusing-workflows .

Yes I think it is a bit annoying, too. Should I do that now or is that a task for later?

Yes I think it is a bit annoying, too. Should I do that now or is that a task for later?

I think we can defer it but should prioritize it.

I will make a task for it.

cqc-alec · 2022-03-03T11:17:15Z

.github/workflows/valgrind.yml

@@ -3,6 +3,7 @@ on:
  pull_request:
    branches:
      - develop
+      - develop2


Still there?

cqc-melf added 3 commits March 1, 2022 16:00

copy files

1700a16

changes for v2

57a60cb

add create PR on merge to develop

db86fa3

cqc-melf requested a review from cqc-alec March 1, 2022 17:30

cqc-melf added 2 commits March 1, 2022 20:36

Merge branch 'develop' into update-workflows-v2

1d79442

Merge branch 'develop' into update-workflows-v2

c64ee85

cqc-alec requested changes Mar 2, 2022

View reviewed changes

cqc-melf and others added 7 commits March 2, 2022 15:56

Update .github/workflows/docs_v2.yml

85524c3

Co-authored-by: Alec Edgington <[email protected]>

commit chagnes from PR

5b2204d

Merge branch 'update-workflows-v2' of github.com:CQCL/tket into updat…

4f8b997

…e-workflows-v2

rename branch

8327116

Merge branch 'develop' into update-workflows-v2

6d20561

add merge from develop, cancel jobs

0408239

Merge branch 'update-workflows-v2' of github.com:CQCL/tket into updat…

23c99e1

…e-workflows-v2

cqc-melf requested a review from cqc-alec March 2, 2022 15:09

cqc-melf and others added 4 commits March 2, 2022 17:09

Merge branch 'develop' into update-workflows-v2

8d09d6e

merge

3218f8f

Merge branch 'update-workflows-v2' of github.com:CQCL/tket into updat…

09c8c2d

…e-workflows-v2

add valgrind for develop2

6215eaf

revert mistake

f5b78f1

cqc-alec requested changes Mar 2, 2022

View reviewed changes

cqc-melf added 4 commits March 2, 2022 17:20

executable

72751a1

add nightly check for valgrind

bf9a5f4

add nightly for build

cb409b8

update branch selection for nightly

42daf9f

cqc-melf requested a review from cqc-alec March 2, 2022 17:35

cqc-alec requested changes Mar 3, 2022

View reviewed changes

change names of the workflows

16eaa47

cqc-melf requested a review from cqc-alec March 3, 2022 11:07

cqc-alec requested changes Mar 3, 2022

View reviewed changes

.github/workflows/valgrind.yml Outdated

@@ -3,6 +3,7 @@ on:

pull_request:

branches:

- develop

- develop2

Copy link

Collaborator

cqc-alec Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there?

remove develop2 from valgrind check

84ca79c

cqc-alec approved these changes Mar 3, 2022

View reviewed changes

cqc-melf merged commit 6783400 into develop Mar 3, 2022

cqc-melf deleted the update-workflows-v2 branch March 3, 2022 12:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TKET-1847] Update workflows for tket v2 #265

[TKET-1847] Update workflows for tket v2 #265

cqc-melf commented Mar 1, 2022

cqc-melf commented Mar 1, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-alec left a comment

cqc-alec Mar 2, 2022

cqc-alec Mar 2, 2022

cqc-melf Mar 2, 2022

cqc-melf commented Mar 2, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022 •

edited

Loading

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

cqc-melf Mar 3, 2022

cqc-alec Mar 3, 2022

[TKET-1847] Update workflows for tket v2 #265

[TKET-1847] Update workflows for tket v2 #265

Conversation

cqc-melf commented Mar 1, 2022

cqc-melf commented Mar 1, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-melf commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-alec commented Mar 2, 2022

cqc-alec left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cqc-melf commented Mar 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cqc-alec Mar 3, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cqc-alec Mar 3, 2022 •

edited

Loading