Remove Backend.characterisation
#226
Conversation
pytket/pytket/tailoring/__init__.py
Outdated
| The circuit module provides an API to interact with the tket | ||
| :py:class:`Characterisation` suite, with methods for noise shaping, characterisation and | ||
| mitigation. This module is provided in binary form during the PyPI installation. | ||
| The `tailoring` module provides an API to interact with tket's charcterisation suite, |
There was a problem hiding this comment.
Maybe this isn't the PR for it, but faithfully the tailoring module only provides an API for using frame randomisation methods, and maybe we should rename the whole module to frame randomisation in another PR?
If we save that for another review, it should be tket's characterisation suite.
There was a problem hiding this comment.
OK, I'll revert this.
There was a problem hiding this comment.
Done. (Just me being lazy, I saw it was referring to the wrong module name and thought I'd correct it at the same time. But yes it should be a new PR.)
This reverts commit 98ca10d.
The changes in #214 will also break things in extensions, should the fixes be sister PRs? |
Good point. Maybe we should do a pre-release first without this change, fix those, and then do another pre-release with this change? |
Actually, removing this doesn't break the extensions, so I'm going to merge and attempt another pre-release now. (For some reason I'm having difficulty doing a pre-release. Seems the wrong version number is being applied by setuptools_scm on some platforms...) |
After merging this I'll make a pytket pre-release and then update the extensions.