Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Removed Backend.get_<data> methods #20

Merged
merged 7 commits into from
Sep 30, 2021
Merged

[refactor] Removed Backend.get_<data> methods #20

merged 7 commits into from
Sep 30, 2021

Conversation

lmondada
Copy link
Contributor

I am currently making the necessary changes to pytket-extensions

@lmondada
Copy link
Contributor Author

We're putting this on hold until we have cleared how exactly we'd like to do this.

@lmondada lmondada changed the title [refactor] Removed Backend.get_<data> methods WIP [refactor] Removed Backend.get_<data> methods Sep 22, 2021
@lmondada lmondada force-pushed the refactor/remove_get_data branch from 8a12cbc to bd93d03 Compare September 29, 2021 15:06
@lmondada lmondada force-pushed the refactor/remove_get_data branch from bd93d03 to de48bbd Compare September 29, 2021 15:09
@lmondada lmondada marked this pull request as ready for review September 29, 2021 15:14
@lmondada lmondada requested a review from cqc-alec September 29, 2021 15:14
@lmondada lmondada changed the title WIP [refactor] Removed Backend.get_<data> methods [refactor] Removed Backend.get_<data> methods Sep 29, 2021
@lmondada
Copy link
Contributor Author

I'm now going to update the extensions.

@lmondada
Copy link
Contributor Author

A draft pytket-extensions PR has been opened: CQCL/pytket-extensions#202. When this is merged in, we can run the CI tests on the extensions.

cqc-alec
cqc-alec requested changes Sep 29, 2021
View reviewed changes
pytket/pytket/backends/backend.py Outdated Show resolved Hide resolved
pytket/pytket/backends/backend.py Outdated Show resolved Hide resolved
pytket/pytket/backends/backend.py Outdated Show resolved Hide resolved
pytket/pytket/backends/backend.py Outdated Show resolved Hide resolved
pytket/pytket/backends/backend.py Outdated Show resolved Hide resolved
@lmondada lmondada force-pushed the refactor/remove_get_data branch from 524856c to 137e84d Compare September 30, 2021 08:16
@lmondada lmondada requested a review from cqc-alec September 30, 2021 08:17
cqc-alec
cqc-alec approved these changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; after merging we can make a candidate release to enable the extensions and manual/examples to be updated.

@lmondada lmondada merged commit 2ebd6e5 into develop Sep 30, 2021
@lmondada lmondada deleted the refactor/remove_get_data branch September 30, 2021 12:43
lmondada added a commit to CQCL/pytket-extensions that referenced this pull request Sep 30, 2021
@lmondada
[all] Reflected API changes in CQCL/tket#20 (#202)
5f40bd8
lmondada added a commit to CQCL/pytket-docs that referenced this pull request Oct 13, 2021
@lmondada
Reflected API changes in CQCL/tket#20
1c12cfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmondada @cqc-alec