Add ruff check to CI and clean up Python #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
reviewed
Nov 7, 2024
Co-authored-by: cqc-melf <[email protected]>
cqc-alec
commented
Nov 8, 2024
cqc-melf
reviewed
Nov 8, 2024
| "A", | ||
| "AIR", | ||
| # "ANN", | ||
| # "ARG", # TODO |
There was a problem hiding this comment.
is there an issues that we could link?
There was a problem hiding this comment.
I can make an issue to come back and address some of these.
cqc-melf
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1639 .
I've configured ruff to ignore a few rules but we might want to address these as well in future (in particular we should probably use
__all__in init files instead of importing with wildcards).