Deconstruct classical conditions in terms of ClExprOp instead of ClassicalExpBox
#1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
changed the title
ClExprOp instead of ClassicalExpBox
cqc-alec
force-pushed
the
ae/addcondition
branch
from
0172850 to
f8265b0
Compare
cqc-alec
force-pushed
the
ae/addcondition
branch
from
f8265b0 to
ea8ae1f
Compare
cqc-alec
commented
Nov 5, 2024
| @@ -1115,178 +1115,6 @@ def check_serialization_roundtrip(circ: Circuit) -> None: | |||
| assert circ_from_dict.to_dict() == circ_dict | |||
|
|
|||
|
|
|||
| def test_decomposition_known() -> None: | |||
There was a problem hiding this comment.
Next step after this will be to write a new decomposition pass, at which point I'll add a corresponding test to replace this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change int type in expressions to
uint64_t, since otherwise pybind11 assumes 32 bits.