Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to pytket-quest extensions docs #1648

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

CalMacCQ
Copy link
Contributor

@CalMacCQ CalMacCQ commented Nov 1, 2024

Description

Adding a crosslink to the extensions index to mention pytket-quest. Should I also mention quest explicitly as a density matrix simulator?

Driveby: mention AerDensityMatrixBackend from pytket-qiskit which was left out until now.

@CalMacCQ CalMacCQ requested a review from ferbetanzo November 1, 2024 14:26
Copy link
Collaborator

@ferbetanzo ferbetanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we need to mention QuEST in the list of "Density Matrix Simulators" too, given that you use the same QuESTBackend for performing both kinds of simulation and by default it will do state vector simulation.

I can see that the QulacsBackend can also do state vector and density matrix simulations, and by default it also does state vector simulations, however we are listing it as a density matrix simulator in the docs. Do you know why this is?

@CalMacCQ
Copy link
Contributor Author

CalMacCQ commented Nov 1, 2024

I'm not sure if we need to mention QuEST in the list of "Density Matrix Simulators" too, given that you use the same QuESTBackend for performing both kinds of simulation and by default it will do state vector simulation.

I can see that the QulacsBackend can also do state vector and density matrix simulations, and by default it also does state vector simulations, however we are listing it as a density matrix simulator in the docs. Do you know why this is?

I take your point. I guess you have to explicitly enable DM simulation with qulacs. Maybe we should remove the separate mention for qulacs for consistency. Not sure.

I'm happy just mentioning quest as a SV simulator

@CalMacCQ CalMacCQ merged commit 9354613 into main Nov 1, 2024
30 checks passed
@CalMacCQ CalMacCQ deleted the docs/pytket-quest branch November 1, 2024 14:55
CalMacCQ added a commit that referenced this pull request Nov 1, 2024
* add pytket-quest link to sidebar

* add AerDensityMatrixBackend

* add quest to list of SV simulators

* fix bad link syntax
CalMacCQ added a commit that referenced this pull request Nov 14, 2024
* add pytket-quest link to sidebar

* add AerDensityMatrixBackend

* add quest to list of SV simulators

* fix bad link syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants