Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for mypy. #160

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Fixes for mypy. #160

merged 4 commits into from
Jan 4, 2022

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Jan 4, 2022

No description provided.

RolandMacDoland
RolandMacDoland previously approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@RolandMacDoland RolandMacDoland dismissed their stale review January 4, 2022 16:50

Failing tests

@RolandMacDoland RolandMacDoland self-requested a review January 4, 2022 16:50
@cqc-alec
One more mypy fix.
54998ee 
This one only showed up with numpy 1.22.
RolandMacDoland
RolandMacDoland reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but the failing tests seem to persist.

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented Jan 4, 2022

Looking good but the failing tests seem to persist.

It hasn't failed yet!

@RolandMacDoland
Copy link
Contributor

Looking good but the failing tests seem to persist.

It hasn't failed yet!

It referred to the state prior to your last commit.

RolandMacDoland
RolandMacDoland approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cqc-alec cqc-alec merged commit ac877e8 into develop Jan 4, 2022
@cqc-alec cqc-alec deleted the bugfix/mypy branch January 4, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqc-alec @RolandMacDoland