Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to libs README about building libraries #1592

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

cqc-alec
Copy link
Collaborator

Description

I don't think we should change the default user and channel, since these labels are meant to inidicate "published" versions. For local library development and testing it's correct to use no labels.

Related issues

Closes #1529 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec requested review from cqc-melf and zrho September 20, 2024 10:16
@cqc-alec cqc-alec merged commit 7e2a51c into main Sep 20, 2024
29 checks passed
@cqc-alec cqc-alec deleted the ae-libuserchannel branch September 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies between the libraries when building with conan
2 participants