Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post benchmarking results to slack #1417

Merged
merged 4 commits into from
May 28, 2024
Merged

Post benchmarking results to slack #1417

merged 4 commits into from
May 28, 2024

Conversation

daniel-mills-cqc
Copy link
Contributor

@daniel-mills-cqc daniel-mills-cqc commented May 28, 2024 •
edited
Loading

Description

Post single number metric to slack, move to running single number metric on release.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@github-actions GitHub Actions
Copy link

Compiler PytketIBMQ is best, or equal best on, 14.912280701754383% for circuits.

@daniel-mills-cqc daniel-mills-cqc marked this pull request as ready for review May 28, 2024 10:22
@daniel-mills-cqc daniel-mills-cqc requested a review from cqc-alec May 28, 2024 10:23
@daniel-mills-cqc daniel-mills-cqc linked an issue May 28, 2024 that may be closed by this pull request
Move compiler comparison to releases only, and to private output #1415
Closed
cqc-alec
cqc-alec reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the "Create comment" job do anything when this isn't triggered by a PR? Can we delete it?

.github/workflows/pytket_benchmarking.yml
@@ -77,6 +76,7 @@ jobs:
run: |
pip install pytket-*.whl
pip install --pre --index-url https://github_actions:${{ secrets.PRIVATE_PYPI_PASS }}@cqcpythonrepository.azurewebsites.net/simple/ pytket_benchmarking
pip list
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like just to see which version of pytket is being installed the first couple of times this runs. Just wanting to be careful that installing pytket_benchmarking does not require a conflicting version. I think I have checked this before but would like to be doubly sure.

@daniel-mills-cqc
Copy link
Contributor Author

daniel-mills-cqc commented May 28, 2024 •
edited
Loading

Does the "Create comment" job do anything when this isn't triggered by a PR? Can we delete it?

Oops, forgot to remove that. Now gone.

@daniel-mills-cqc daniel-mills-cqc requested a review from cqc-alec May 28, 2024 11:11
@daniel-mills-cqc daniel-mills-cqc merged commit 9f349bb into main May 28, 2024
29 checks passed
@daniel-mills-cqc daniel-mills-cqc deleted the benchmarking_to_slack branch May 28, 2024 11:25
@daniel-mills-cqc
Copy link
Contributor Author

Thanks! I'll keep an eye on the next release to check if this worked as planned.

CalMacCQ added a commit that referenced this pull request Jun 17, 2024
@CalMacCQ @yao-cqc
@dependabot @cqc-alec @sjdilkes @daniel-mills-cqc @cqc-melf
Docs: pytket v1.29 release update (#1448)
81bca7f 
* Allow barriers when dagger or transpose circuits (#1400)

* Allow barriers in dagger() and transpose()

* bump tket version

* add changelog entry

* Format test

* Bump cachix/install-nix-action from 26 to 27 (#1403)

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 26 to 27.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](cachix/install-nix-action@v26...V27)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/add-to-project from 0.6.1 to 1.0.1 (#1404)

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.6.1 to 1.0.1.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](actions/add-to-project@v0.6.1...v1.0.1)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use `ubuntu-24.04` on CI (#1401)

* Add OpType.CnRx and OpType.CnRz (#1405)

* Add CnRx and CnRz

* Update circuit_test.py

* re clang format

* regen stubs

* Update changelog.rst

* bump version

* Unbump changelog...

oops

* Update ControlledGates.cpp

* split controlled phase gate decomp

* Update circuit_test.py

* Update OpType.hpp

* Update `place_fully_connected` (#1409)

* update place_fully_connected

* Update placement.cpp

* Update placement_test.py

* Bump cachix/cachix-action from 14 to 15 (#1416)

Bumps [cachix/cachix-action](https://github.com/cachix/cachix-action) from 14 to 15.
- [Release notes](https://github.com/cachix/cachix-action/releases)
- [Commits](cachix/cachix-action@v14...v15)

---
updated-dependencies:
- dependency-name: cachix/cachix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Post benchmarking results to slack (#1417)

* Post results to slack

* Remove run on PR

* Remove documentation

* Remove pr comment

* Refactor auto rebase and auto squash (#1410)

* Implement python rebase functions in C++

* Implement auto_rebase in c++

* Implement auto_squash in c++

* Test exception handling

* Add AutoRebase, AutoSquash to binder

* Update circuit_library

* Update json schema

* deprecate auto_rebase and auto_squash

* Fix bug

* Replace auto_rebase_pass and auto_squash_pass with AutoRebase and AutoSquash

* Remove auto_rebase_pass and auto_squash_pass from docs

* Bump tket version

* Remove extra lines in docs

* Regenerate stubs

* Add changelog entry

* Fix linting errors

* Sorted gate sets in serialisation

* Better deprecation handling

* Add docs for added CircPool functions

* Add comment to hard-to-understand test

* Fix typo in json schema

* Replace `find()` with `contains()`

* Set `always_squash_symbols` to false when squash `Rz` and `PhasedX`

* Revert to using ubuntu-22.04 runner for valgrind checks. (#1432)

* Handle `NPhasedX` gates in `decompose_cliffords_std()` (#1431)

* Add workflow to mark stale issues and PRs. (#1437)

* update remove blank wires to keep classical bits (#1435)

* update remove blank wires

* add testcase

* update changelog

* update tket version

* update testcases

* update regen stubs

* fix typo

* add param to remove_classical_wire in python

* regen stubs

* Update pytket/docs/changelog.rst

Co-authored-by: Alec Edgington <[email protected]>

* rename parameter to keep_blank_classical_wires

* update tket version

* fix param

* Update pytket/binders/circuit/Circuit/main.cpp

Co-authored-by: Alec Edgington <[email protected]>

* Update pytket/binders/circuit/Circuit/main.cpp

Co-authored-by: Alec Edgington <[email protected]>

* Update pytket/pytket/_tket/circuit.pyi

Co-authored-by: Alec Edgington <[email protected]>

* update testcases to use bits and qubits

* regen stubs

---------

Co-authored-by: Alec Edgington <[email protected]>

* Try running ZX test with all Python versions. (#1438)

* Update Windows compiler version. (#1442)

* Fix FlattenRelabelRegistersPass (#1441)

* update tket version

* update parameter of remove_blank_wires in gen_flatten_relabel_registers_pass

* add python testcase for compilation pass flatten_relabel

* update tket version

* Allow classical transforms and predicates on up to 64 bits (#1446)

* Update docs and changelog for 1.29.0 release. (#1447)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: yao-cqc <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alec Edgington <[email protected]>
Co-authored-by: Silas Dilkes <[email protected]>
Co-authored-by: Dan Mills <[email protected]>
Co-authored-by: cqc-melf <[email protected]>
CalMacCQ added a commit that referenced this pull request Jun 18, 2024
@CalMacCQ @yao-cqc
@dependabot @cqc-alec @sjdilkes @daniel-mills-cqc @cqc-melf
Update docmain branch for pytket 1.29.2 (#1455)
73ecce2 
* Allow barriers when dagger or transpose circuits (#1400)

* Allow barriers in dagger() and transpose()

* bump tket version

* add changelog entry

* Format test

* Bump cachix/install-nix-action from 26 to 27 (#1403)

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 26 to 27.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](cachix/install-nix-action@v26...V27)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump actions/add-to-project from 0.6.1 to 1.0.1 (#1404)

Bumps [actions/add-to-project](https://github.com/actions/add-to-project) from 0.6.1 to 1.0.1.
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](actions/add-to-project@v0.6.1...v1.0.1)

---
updated-dependencies:
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Use `ubuntu-24.04` on CI (#1401)

* Add OpType.CnRx and OpType.CnRz (#1405)

* Add CnRx and CnRz

* Update circuit_test.py

* re clang format

* regen stubs

* Update changelog.rst

* bump version

* Unbump changelog...

oops

* Update ControlledGates.cpp

* split controlled phase gate decomp

* Update circuit_test.py

* Update OpType.hpp

* Update `place_fully_connected` (#1409)

* update place_fully_connected

* Update placement.cpp

* Update placement_test.py

* Bump cachix/cachix-action from 14 to 15 (#1416)

Bumps [cachix/cachix-action](https://github.com/cachix/cachix-action) from 14 to 15.
- [Release notes](https://github.com/cachix/cachix-action/releases)
- [Commits](cachix/cachix-action@v14...v15)

---
updated-dependencies:
- dependency-name: cachix/cachix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Post benchmarking results to slack (#1417)

* Post results to slack

* Remove run on PR

* Remove documentation

* Remove pr comment

* Refactor auto rebase and auto squash (#1410)

* Implement python rebase functions in C++

* Implement auto_rebase in c++

* Implement auto_squash in c++

* Test exception handling

* Add AutoRebase, AutoSquash to binder

* Update circuit_library

* Update json schema

* deprecate auto_rebase and auto_squash

* Fix bug

* Replace auto_rebase_pass and auto_squash_pass with AutoRebase and AutoSquash

* Remove auto_rebase_pass and auto_squash_pass from docs

* Bump tket version

* Remove extra lines in docs

* Regenerate stubs

* Add changelog entry

* Fix linting errors

* Sorted gate sets in serialisation

* Better deprecation handling

* Add docs for added CircPool functions

* Add comment to hard-to-understand test

* Fix typo in json schema

* Replace `find()` with `contains()`

* Set `always_squash_symbols` to false when squash `Rz` and `PhasedX`

* Revert to using ubuntu-22.04 runner for valgrind checks. (#1432)

* Handle `NPhasedX` gates in `decompose_cliffords_std()` (#1431)

* Add workflow to mark stale issues and PRs. (#1437)

* update remove blank wires to keep classical bits (#1435)

* update remove blank wires

* add testcase

* update changelog

* update tket version

* update testcases

* update regen stubs

* fix typo

* add param to remove_classical_wire in python

* regen stubs

* Update pytket/docs/changelog.rst

Co-authored-by: Alec Edgington <[email protected]>

* rename parameter to keep_blank_classical_wires

* update tket version

* fix param

* Update pytket/binders/circuit/Circuit/main.cpp

Co-authored-by: Alec Edgington <[email protected]>

* Update pytket/binders/circuit/Circuit/main.cpp

Co-authored-by: Alec Edgington <[email protected]>

* Update pytket/pytket/_tket/circuit.pyi

Co-authored-by: Alec Edgington <[email protected]>

* update testcases to use bits and qubits

* regen stubs

---------

Co-authored-by: Alec Edgington <[email protected]>

* Try running ZX test with all Python versions. (#1438)

* Update Windows compiler version. (#1442)

* Fix FlattenRelabelRegistersPass (#1441)

* update tket version

* update parameter of remove_blank_wires in gen_flatten_relabel_registers_pass

* add python testcase for compilation pass flatten_relabel

* update tket version

* Allow classical transforms and predicates on up to 64 bits (#1446)

* Update docs and changelog for 1.29.0 release. (#1447)

* Update MultiplexedTensoredU2Box Circuit Construction (#1443)

* First changes, compiling but returning incorrect results

* MultiplexedU2Box construction working

* hmm

* refactor to separate

* Update Multiplexor.cpp

* Working on specific cases

* Update test_Multiplexor.cpp

* Update test_Multiplexor.cpp

* working on most cases ...

* Refactor into separate methods

* refactor again and neaten code up

* Tidied, failling test for mystery reasons, moving on ...

* Multiplexed-rz with interleaved gates

* Tidy for PR

* bump

* Update Multiplexor.hpp

* Update Multiplexor.hpp

* Update test_Multiplexor.cpp

* Update Multiplexor.cpp

* attempt to remove mismatch ??

* Update Multiplexor.cpp

* Update Multiplexor.cpp

* fix

* changes

* update rz rotation indexing

* add asserts

* update error threshold

* add multiple constructors

* bump

* Update changelog.rst

* Revert switch from 32- to 64-bit maximum width (#1449)

* Update docs and changelog for 1.29.1 release. (#1451)

* Revert to removing blank classical wires in `FlattenRelabelRegistersPass` (#1453)

* Update docs and changelog for 1.29.2 release. (#1454)

* remove space

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: yao-cqc <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alec Edgington <[email protected]>
Co-authored-by: Silas Dilkes <[email protected]>
Co-authored-by: Dan Mills <[email protected]>
Co-authored-by: cqc-melf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move compiler comparison to releases only, and to private output
2 participants
@daniel-mills-cqc @cqc-alec