Ensure MacOS arm64 wheels are compatible with MacOS 12 and above #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
changed the title
cqc-melf
reviewed
Apr 19, 2024
| - name: Build wheel | ||
| run: | | ||
| conan create recipes/pybind11 | ||
| conan create recipes/pybind11_json/all --version 0.2.13 | ||
| cd pytket | ||
| # Ensure wheels are compatible with MacOS 12.0 and later: | ||
| export WHEEL_PLAT_NAME=macosx_12_0_arm64 | ||
| python${{ matrix.python-version }} -m pip install -U pip build | ||
| python${{ matrix.python-version }} -m pip install delocate~=0.10.7 | ||
| python${{ matrix.python-version }} -m pip install -U pip build delocate |
There was a problem hiding this comment.
You have removed here the version constrains for delocate completely?
There was a problem hiding this comment.
Yes -- the only reason for pinning to 0.10.7 was that 0.11 started doing extra checks for compatibility and so produced wheels that were only compatible with MacOS 14. But with this change, delocate 0.11 produces MacOS-12-compatible wheels.
cqc-melf
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that the dependencies (specifically the tklog and tket shared libraries) are built for MacOS 12 compatibility, so that delocate is happy.
Maybe we got away with not doing this before by sheer luck, or maybe this will actually fix some of the issues people have been having with installing pytket in conda environments.
Release workflow tested here.
Related issues
Closes #1344 .
Checklist