Feature/hardcode c3x, c4x decompositions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
requested changes
Dec 9, 2021
tket/src/Circuit/CircPool.cpp
Outdated
| return *C; | ||
| } | ||
|
|
||
| const Circuit &RC3X_normal_decomp() { |
There was a problem hiding this comment.
This function is only used in this file so should be static.
tket/src/Circuit/CircPool.cpp
Outdated
| return *C; | ||
| } | ||
|
|
||
| const Circuit &RC3X_normal_decomp() { |
There was a problem hiding this comment.
Can you add a comment describing what this returns? It isn't obvious from the name.
tket/src/Circuit/CircPool.cpp
Outdated
| return *C; | ||
| } | ||
|
|
||
| const Circuit &C3SX_normal_decomp() { |
There was a problem hiding this comment.
Similarly for this function:
- make
static; - add comment describing what it does.
tket/src/Circuit/CircPool.hpp
Outdated
| /** Equivalent to CCCX, using 14 CX */ | ||
| const Circuit &C3X_normal_decomp(); | ||
|
|
||
| /** Equivalent to CCCCX, using 30 CX */ |
There was a problem hiding this comment.
By my calculation this should be 36:
CU1_using_CX: 2
RC3X_normal_decomp: 6
C3SX_normal_decomp: 7 x CU1_using_CX + 6 = 7 x 2 + 6 = 20
C4X_noemal_decomp: 2 x CU1_using_CX + 2 x RC3X_normal_decomp + C3SX_normal_decomp = 2 x 2 + 2 x 6 + 20 = 36
There was a problem hiding this comment.
Ahh sorry, I used the CX count in C3X instead of C3SX when counting the number of CXs in C4X.
cqc-alec
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improved our CnX decomposition for n <= 10.