Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions. #1274

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Throw exceptions. #1274

merged 5 commits into from
Mar 11, 2024

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented Mar 7, 2024

Description

We were just constructing these exceptions without throwing them. This led to a segfault.

Related issues

Fixes #1243 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-alec cqc-alec requested a review from yao-cqc March 7, 2024 13:49
@cqc-alec cqc-alec marked this pull request as ready for review March 7, 2024 13:49
@cqc-alec cqc-alec merged commit 4fb9dde into develop Mar 11, 2024
30 checks passed
@cqc-alec cqc-alec deleted the bugfix/fromdict branch March 11, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-cqc yao-cqc yao-cqc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when calling Circuit.from_dict with some dicts
2 participants
@cqc-alec @yao-cqc