Update Noise Aware Placement for Circuits with only single qubit gates #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#922 brings up that qubits without 2-qubit gates aren't placed by
NoiseAwarePlacement
. This is fine forGraphPlacement
as these qubits will be dynamically assigned during routing, with their allocation unrelated to performance as it assumes "no noise", but forNoiseAwarePlacement
they could still be assigned toNode
in theArchitecture
that have smaller error rates.However, the expectation is that typical circuits won't have qubits without any 2-qubit gates, i.e. this is a special case fix. My proposed solution is:
• If the Circuit has qubits with 2-qubit gates and qubits without 2-qubit gates, don't assign the qubits without 2-qubit gates to any
Node
, as theseNode
may be better used as dynamically assigned later.• If the Circuit only has qubits without 2-qubit gates, then assign them to the
Node
with best reported error-rates.This changes two previous tests that were seeing how
NoiseAwarePlacement
worked on circuits with no 2-qubit gates. In particular, these tests assumed they would be assigned to theunplaced
register, while now they are assigned to anyArchitecture
Node
. I have considered this a fine change & minor change in behaviour as this not an impactful change for any realistic circuits.Checklist