Fix #1101: correct Nix pytket setup version #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core pytket project uses setuptools_scm to extract version information from .git. This would be awkward in Nix as it would involve copying the .git directory into the pytket source. As we already have the version extracted from another file in the project, which is used to set the version number on the Nix side, we can instead hardcode this version number into setup.py when copying it to the derivation source.
cqc-alec
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the version was set in the nix build, but was not bubbled to the python project metadata. This was problematic, as shown in #1101. The root cause was that, although the copying of _version.py was done, the initial build stage did not have access to the version from .git, via setuptools_scm.
Rather than copying .git into the nix store, the version is already known and can be injected into setup.py directly. It might require further work to identify a more future-proof, universal approach, but this avoids modifications that might impact non-nix builds.