Remove docs build warning from pydata-sphinx-theme 0.14.2 and upgra…
#1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de sphinx version (#1093) * remove unused pygment * try navigation_with_keys fix * remove unused intersphinx extension for now * remove sphinx version restriction * Show sphinx version in doc footer * use sphinx <7 * remove show_sphinx flag
CalMacCQ
reviewed
Oct 26, 2023
| @@ -55,7 +55,6 @@ | |||
| extensions = [ | |||
| "sphinx.ext.autodoc", | |||
| "sphinx.ext.autosummary", | |||
| "sphinx.ext.intersphinx", | |||
There was a problem hiding this comment.
I don't think we need to remove this actually. We can probably add this back in.
We may want to use this in future.
There was a problem hiding this comment.
If we changes this here now we will have a merge conflict later on, is it okay to keep it like this?
trvto
approved these changes
Oct 26, 2023
CalMacCQ
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having some problems with the docs not building on another repo which pulls from main.
I have cherry picked the fix for the build problem, it should work now.
It is not intended to have a release after this is merged.
…de sphinx version (#1093)
remove unused pygment
try navigation_with_keys fix
remove unused intersphinx extension for now
remove sphinx version restriction
Show sphinx version in doc footer
use sphinx <7
remove show_sphinx flag