Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/arg ordering in classical exp box #1092

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

trvto
Copy link
Contributor

@trvto trvto commented Oct 24, 2023

  • Added LogicalExp.all_inputs_ordered and use it where all_inputs was used in the qasm code
  • Would have just changed the all_inputs method but it would require a breaking change (returning list instead of set)

Fixes #1086

@trvto trvto requested review from cqc-alec and cqc-melf and removed request for cqc-alec October 24, 2023 12:44
Copy link
Contributor

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add something to the changelog, besides that it is looking good

@trvto
Copy link
Contributor Author

trvto commented Oct 24, 2023

It would be good to add something to the changelog, besides that it is looking good

done

@trvto trvto requested a review from cqc-melf October 24, 2023 13:52
@trvto trvto merged commit 47f407c into develop Oct 24, 2023
31 checks passed
@trvto trvto deleted the bugfix/arg-ordering-in-classical-exp-box branch October 24, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arguments of commands for register expressions converted from QASM are in random order
2 participants