Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move OpBox to a new module #35

Merged
merged 1 commit into from
Apr 5, 2024
Merged

refactor: Move OpBox to a new module #35

merged 1 commit into from
Apr 5, 2024

Conversation

aborgna-q
Copy link
Collaborator

Adds a new opbox.rs file and moves OpBox there, to keep the code clean.

@aborgna-q aborgna-q requested a review from johnchildren April 5, 2024 11:56
@aborgna-q aborgna-q enabled auto-merge April 5, 2024 11:58
@aborgna-q aborgna-q added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 93e813b Apr 5, 2024
5 checks passed
@aborgna-q aborgna-q deleted the refactor/modules branch April 5, 2024 12:00
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 8, 2024
## 🤖 New release
* `tket-json-rs`: 0.3.1 -> 0.4.0 (⚠️ API breaking changes)

### ⚠️ `tket-json-rs` breaking changes

```
--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/enum_missing.ron

Failed in:
  enum tket_json_rs::circuit_json::OpBox, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:67
  enum tket_json_rs::circuit_json::ToffoliBoxSynthStrat, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:302

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/struct_missing.ron

Failed in:
  struct tket_json_rs::circuit_json::BoxID, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:58
  struct tket_json_rs::circuit_json::PauliStabiliser, previously in file /tmp/.tmpVNdz4z/tket-json-rs/src/circuit_json.rs:51
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## 0.4.0 (2024-04-08)

### Bug Fixes

- Add missing OpTypes
([#37](#37))

### Miscellaneous Tasks

- [**breaking**] Update pyo3 to 0.21
([#33](#33))

### Refactor

- Move `OpBox` to a new module
([#35](#35))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Agustín Borgna <[email protected]>
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants