Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Check for missing operations automatically #31

Closed
aborgna-q opened this issue Mar 26, 2024 · 0 comments · Fixed by #36
Closed

ci: Check for missing operations automatically #31

aborgna-q opened this issue Mar 26, 2024 · 0 comments · Fixed by #36
Assignees
@aborgna-q
Labels
enhancement New feature or request

Comments

@aborgna-q
Copy link
Collaborator

As a followup for #30, can check for missing ops automatically in CI?
@aborgna-q aborgna-q added the enhancement New feature or request label Mar 26, 2024
@aborgna-q aborgna-q mentioned this issue Apr 5, 2024
Merged
@aborgna-q aborgna-q self-assigned this Apr 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
@aborgna-q
ci: Test missing op definitions against pytket (#36)
577f44e 
Adds an integration tests that checks whether all elements of
`pytket.OpType.__members__` are present in the `OpType` enum.

Adds a CI check for this that runs on pull requests / merges as well as
on a cron job every day to ensure that new pytket releases are always
tested.

This test currently fails with the following message:
```
Missing optypes in `tket_json_rs`:
  - Phase
  - CS
  - CSdg
  - TermSequenceBox
  - ConjugationBox
  - DummyBox
  - CnY
  - CnZ
  - WASM
  - MultiplexedTensoredU2Box
  - StatePreparationBox
  - DiagonalBox
Please add them to the `OpType` enum in `tket_json_rs/src/optype.rs`.
```

I'll open another PR with those implementations.

Ideally the cron job would also create an issue when the test fails, but
I'll look into that another time.

Closes #31 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Test missing op definitions against pytket CQCL/tket-json-rs
1 participant
@aborgna-q