-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if default two qubit gate is supported by the device #472
Conversation
f9d9f13
to
5f918e8
Compare
Can we instead check this in the |
Unfortunately I can't use _gate_set in the constructor because that calls the API and breaks quiet a few things for backends constructed with the offlineapi. Happy to find a workaround for that if you think that is important. |
It does feel wrong to set this config value inside rebase_pass(). Can we change the |
By the way, |
I think |
I think we discussed this in the last sprint planing that we still want to have this check additionally to make this future proof. If you think this is not required, then we can close this. |
I think I was wrong with the problem detection, the actual issue is that we have tests are not expected to make API calls that would make this calls with the changes in the constructor. I have now gone the way and updated all the affected testcases. |
…-quantinuum into melf/fix-unsupported-2q-gate
The failed tests on QA are timeouts, so should be fine to merge without them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just a little worried that requiring login when constructing QuantinuumBackend
may break some workflows; perhaps we should check this with nexus?
I checked with them, this is not a concern. |
I will take a look at the failed notebook and update that. Will ask for a review after that is updated. |
This is probably #474 . If so it needs an update from the US side. |
This reverts commit e89a991.
@@ -1038,7 +1038,7 @@ def process_circuits( | |||
"max_classical_register_width", 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to change the default we should change it here too, but I'm not sure if we want to do this.
Description
Solve #457
Checklist