fix: improve implicit qubit permutations warning #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMacCQ
commented
Nov 21, 2024
tests/qiskit_convert_test.py
Outdated
| with pytest.warns(UserWarning, match="The pytket Circuit contains implicit qubit"): | ||
| tk_to_qiskit(c) | ||
|
|
||
| state_backend = AerStateBackend() |
There was a problem hiding this comment.
I wrote this test without the flag added to ensure that it failed.
The warning only appears for AerBackend and not AerStateBackend. I would've expected both to generate a warning (i.e. record to be of length 2)
There was a problem hiding this comment.
Ah its because the state and unitary backends replace implicit swaps with SWAP gates whereas AerBackend does not.
CalMacCQ
changed the title
CalMacCQ
commented
Nov 21, 2024
| @@ -194,7 +194,7 @@ Every {py:class}`~pytket.backends.backend.Backend` in pytket has its own {py:met | |||
| 2 preserve barriers in a circuit, while optimisation level 3 will remove them. | |||
|
|
|||
| :::{list-table} **Default compilation pass for the IBMQBackend and IBMQEmulatorBackend** | |||
| :widths: 25 25 25 | |||
| :widths: 25 25 25 25 | |||
There was a problem hiding this comment.
This fixes an error due to an invalid number of columns
|
Sorry for commit spam. I think the linting settings were broken in my IDE. |
cqc-alec
reviewed
Nov 21, 2024
| @@ -286,6 +286,7 @@ def process_circuits( | |||
| circuit_batches, batch_order = _batch_circuits(circuits, n_shots_list) | |||
|
|
|||
| replace_implicit_swaps = self.supports_state or self.supports_unitary | |||
| perm_warning = False | |||
There was a problem hiding this comment.
No need to define a variable, it's only used once.
There was a problem hiding this comment.
Fair enough. Done dd6e973
CalMacCQ
changed the title
cqc-alec
requested changes
Nov 22, 2024
Co-authored-by: Alec Edgington <[email protected]>
Co-authored-by: Alec Edgington <[email protected]>
cqc-alec
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the change from #412 back in again with a boolean flag to ensure that unhelpful warnings aren't generated when using
AerBackendwith optimisation level 2See discusssion in #411
Driveby: fix invalid table of compilation passes (see df0cda3)
Related issues
closes #411
Checklist