-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrosstalkParams
to API docs and docs cleanup
#219
Conversation
pytketdoc_base: None, | ||
"https://qiskit.org/documentation/": None, | ||
"http://docs.qulacs.org/en/latest/": None, | ||
"python": ("https://docs.python.org/3/", None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates some deprecated syntax to allow the use of sphinx > 6.2.0
:members: | ||
:special-members: __init__ | ||
|
||
.. automodule:: pytket.extensions.qiskit.backends.crosstalk_model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the three classes CrosstalkParams
, NoisyCircuitBuilder
and FractionalUnitary
.
These are the only three classes which have tests so I assumed they were the only user facing classes. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Only CrosstalkParams
is user facing
:members: | ||
:special-members: __init__ | ||
|
||
.. automodule:: pytket.extensions.qiskit.backends.crosstalk_model | ||
:members: CrosstalkParams, NoisyCircuitBuilder, FractionalUnitary | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a simplier import path for these classes? They do look a bit squashed in the API docs.
@@ -74,28 +75,20 @@ class CrosstalkParams: | |||
Stores various parameters for modelling crosstalk noise | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These types will be automatically inferred by the sphinx-autodoc-typehints extension. We won't have to write them down in multiple places.
:param non_markovian_noise: List storing the non-Markovian noise parameters. | ||
Each tuple in the list contains the qubit index and the zx, zz noise parameters. | ||
:type non_markovian_noise: `List[Tuple[Qubit, float, float]]` | ||
:param virtual_z: If True, then don't break any single qubit Z gate into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sphinx_autodoc_typehints
extension allows these types to be inferred from the source code so we no longer need to put these types in two different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
CrosstalParams
to API docs and docs cleanup
CrosstalParams
to API docs and docs cleanupCrosstalkParams
to API docs and docs cleanup
Closes #210
CrossTalkParams
,FractionalUnitary
andNoisyCircuitBuilder
classes to the API documentation.(Update: Only
CrosstalkParams
is user facing)conf.py
to allow sphinx > 6.2.0IBMQBackend.process_circuit
.