Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate deprecation warnings #196

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Eliminate deprecation warnings #196

merged 8 commits into from
Oct 31, 2023

Conversation

cqc-alec
Copy link
Collaborator

Closes #19 .

There remains one warning (out of 229 initially), but this is coming from inside qiskit.

@cqc-alec cqc-alec marked this pull request as ready for review October 31, 2023 11:12
@cqc-alec cqc-alec requested a review from cqc-melf as a code owner October 31, 2023 11:12
@@ -45,7 +45,8 @@
include_package_data=True,
install_requires=[
"pytket ~= 1.21",
"qiskit ~= 0.44.0",
"qiskit ~= 0.44.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to put this into the changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I forgot to commit it...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -45,7 +45,8 @@
include_package_data=True,
install_requires=[
"pytket ~= 1.21",
"qiskit ~= 0.44.0",
"qiskit ~= 0.44.3",
"qiskit-algorithms ~= 0.2.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cqc-alec cqc-alec requested a review from cqc-melf October 31, 2023 11:20
cqc-melf
cqc-melf previously approved these changes Oct 31, 2023
@cqc-alec cqc-alec merged commit c04a291 into develop Oct 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate warnings from test run
2 participants