AerUnitaryBackend: call transpile before run (#142) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
added a commit
that referenced
this pull request
Aug 29, 2023
doug-q
force-pushed
the
feature/TKT-3333-transpile-aer
branch
from
72ce941 to
4cdd47f
Compare
doug-q
changed the title
doug-q
changed the title
doug-q
force-pushed
the
feature/TKT-3333-transpile-aer
branch
2 times, most recently
from
3a05202 to
1d1825c
Compare
doug-q
force-pushed
the
feature/TKT-3333-transpile-aer
branch
2 times, most recently
from
e285460 to
fb02825
Compare
cqc-alec
reviewed
Sep 6, 2023
tests/backend_test.py
Outdated
|
|
||
| compiled_circ = backend.get_compiled_circuit(circ, optimisation_level=0) | ||
| # using optimisation_level >= 1 does not raise an error | ||
| backend.run_circuit(compiled_circ) |
There was a problem hiding this comment.
Would be nice to have some sort of assertion in the test to check we got the expected result.
There was a problem hiding this comment.
I agree, do you have a suggestion? Otherwise I'll comment that we are testing that run_circuit doesn't throw
There was a problem hiding this comment.
Something like:
r = backend.run_circuit(compiled_circ)
u = r.get_unitary()
assert np.isclose(u[62:64, 62:64], np.asarray([[0., 1.].[1., 0.]]))I think (may have got the syntax wrong, please check). I.e. check that the lower-right 2x2 submatrix of the unitary is the matrix of the X gate.
tests/qiskit_backend_test.py
Outdated
| @@ -107,15 +106,6 @@ def test_unitary() -> None: | |||
| assert np.allclose(u, u2) | |||
|
|
|||
|
|
|||
| def test_cancel() -> None: | |||
There was a problem hiding this comment.
Why was this test deleted?
There was a problem hiding this comment.
Awkward. Bad merge, although I don't understand how. Will revert.
doug-q
force-pushed
the
feature/TKT-3333-transpile-aer
branch
3 times, most recently
from
a5f092b to
b2c7adb
Compare
doug-q
force-pushed
the
feature/TKT-3333-transpile-aer
branch
from
b2c7adb to
4fb4f0a
Compare
cqc-alec
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142