fix(phirgen): emit Skip mop instead of error on global phase #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
force-pushed
the
136-errorrootgate-phase05-unsupported-by-phir
branch
from
3949c6f to
b594781
Compare
|
The test failure seems to be related to #108 |
potential fix for #108
|
@qciaran asking you to review since I introduce an invalid/unknown "Skip" The issue with just ignoring the phase is that if the branches of the conditional are empty, we get an error during phir validation as phir model requires the branches to be non-empty. Now the output corresponding to Phase is: Comment(c='IF ([z_corr_3[0]] == 1) THEN IF ([z_corr_3[0]] == 1) THEN Phase(0.5);'),
IfBlock(metadata=None, block='if', condition=COp(metadata=None, cop='==', returns=None, args=[('z_corr_3', 0), 1]), true_branch=[MOp(metadata=None, mop='Skip', duration=None)], false_branch=None),EDIT: discussed with @qciaran. Will send corresponding PRs for supporting |
cqc-alec
approved these changes
Feb 27, 2024
Asa-Kosto-QTM
approved these changes
Feb 27, 2024
qartik
added a commit
to CQCL/phir
that referenced
this pull request
Feb 27, 2024
This was referenced Feb 27, 2024
qartik
added a commit
to CQCL/phir
that referenced
this pull request
Feb 29, 2024
github-merge-queue bot
pushed a commit
to CQCL/phir
that referenced
this pull request
Feb 29, 2024
* feat(spec): introduce Skip mop See CQCL/pytket-phir#138 * feat(model): add validation for MOps
qartik
added a commit
that referenced
this pull request
Mar 24, 2024
Since conditionals depend on classical bits in their condition, we should create shards for each of them, instead of completely ignoring any dependency that may occur on those classical bits. Fixes: #150 A side effect: We were previously emitting a Skip mop (introduced in #138) for conditional global phase operations, but not they correctly get filtered out by `_is_command_global_phase`
qartik
added a commit
that referenced
this pull request
Mar 24, 2024
Since conditionals depend on classical bits in their condition, we should create shards for each of them, instead of completely ignoring any dependency that may occur on those classical bits. Fixes: #150 A side effect: We were previously emitting a Skip mop (introduced in #138) for conditional global phase operations, but now they correctly get filtered out by `_is_command_global_phase`
qartik
added a commit
that referenced
this pull request
Mar 24, 2024
Since conditionals depend on classical bits in their condition, we should create shards for each of them, instead of completely ignoring any dependency that may occur on those classical bits. Fixes: #150 A side effect: We were previously emitting a Skip mop (introduced in #138) for conditional global phase operations, but now they correctly get filtered out by `_is_command_global_phase`
qartik
added a commit
that referenced
this pull request
Mar 26, 2024
Since conditionals depend on classical bits in their condition, we should create shards for each of them, instead of completely ignoring any dependency that may occur on those classical bits. Fixes: #150 A side effect: We were previously emitting a Skip mop (introduced in #138) for conditional global phase operations, but now they correctly get filtered out by `_is_command_global_phase`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently error out on (global) Phase, which is a problem as global phase is a harmless operation. I propose a no-op
mopinstruction"Skip"instead to handle this scenario.Fixes #136
Type of change
Checklist: