Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec order of sub commands bug fixes #124

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Exec order of sub commands bug fixes #124

merged 6 commits into from
Feb 7, 2024

Conversation

Asa-Kosto-QTM
Copy link
Collaborator

No description provided.

neal-erickson
neal-erickson previously approved these changes Feb 7, 2024
Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions to clean up comments and code.

pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
pytket/phir/phirgen_parallel.py Outdated Show resolved Hide resolved
@qartik
Copy link
Member

qartik commented Feb 7, 2024

Here's a patch containing most of my suggestions, but not all:
parallel.patch

Copy link
Member

@qartik qartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Asa-Kosto-QTM Asa-Kosto-QTM merged commit d18614e into main Feb 7, 2024
6 checks passed
@qartik qartik deleted the 3q-rz-bug branch February 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants