Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ${{github.workspace}} in constraint file path #97

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

trvto
Copy link
Collaborator

@trvto trvto commented Apr 23, 2024

Description

Uses absolute path to dev-tool-requirements.txt on the CI.
Also fixes weird pylint error that went unnoticed because last PRs were force merged

Related issues

fixes #94

Checklist

  • I have performed a self-review of my code.
  • [] I have commented hard-to-understand parts of my code.
  • [ ] I have made corresponding changes to the public API documentation.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [] I have updated the changelog with any user-facing changes.

@trvto trvto requested a review from cqc-melf as a code owner April 23, 2024 09:10
@trvto
Copy link
Collaborator Author

trvto commented Apr 23, 2024

I have no idea why pylint is failing, the error doens't make sense because datetime is used. The error doesn't occur locally...

@trvto trvto force-pushed the fix-dev-tool-requirements-not-found branch from 991c526 to a6dcaeb Compare April 25, 2024 09:23
@trvto trvto force-pushed the fix-dev-tool-requirements-not-found branch from a6dcaeb to 6dbb09f Compare April 25, 2024 09:29
@trvto trvto requested a review from cqc-alec April 25, 2024 09:41
@trvto
Copy link
Collaborator Author

trvto commented Apr 25, 2024

I have no idea why pylint is failing, the error doens't make sense because datetime is used. The error doesn't occur locally...

Fixed it

@trvto trvto merged commit 733aff2 into develop Apr 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci checks not working, 'dev-tool-requirements.txt' can't be opened?
2 participants