Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Melf/add ruff 2024 #120

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Melf/add ruff 2024 #120

merged 8 commits into from
Oct 23, 2024

Conversation

cqc-melf
Copy link
Collaborator

@cqc-melf cqc-melf commented Oct 4, 2024 •
edited
Loading

Description

Please summarise the changes.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@cqc-melf cqc-melf marked this pull request as ready for review October 8, 2024 07:48
@cqc-melf cqc-melf requested a review from cqc-alec October 8, 2024 07:48
cqc-alec
cqc-alec reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to remove all debug and logging? If we want to get rind of print() statements entirely then maybe these should use logging instead?

pytket/extensions/aqt/multi_zone_architecture/circuit_routing/partition_routing.py Outdated
for zone in range(self._arch.n_zones):
changes_str = ", ".join(
", ".join(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string now unused -- delete?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we are deleting all the print() calls. They are presumably for debugging.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff suggested that we should remove the print / replace it with some special log. I think in our case it is fine to have the prints. I have added them back in.

@cqc-melf cqc-melf requested a review from cqc-alec October 22, 2024 17:14
cqc-alec
cqc-alec approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should make an issue to replace these print()s with use of logging.

@cqc-melf cqc-melf merged commit 0358cc0 into main Oct 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqc-melf @cqc-alec