Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fastpath for is_node_convex on a single node #153

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: Fastpath for is_node_convex on a single node #153

merged 1 commit into from
Nov 13, 2024

Conversation

aborgna-q
Copy link
Collaborator

Closes #152

@aborgna-q aborgna-q requested a review from doug-q November 13, 2024 11:42
doug-q
doug-q approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aborgna-q aborgna-q added this pull request to the merge queue Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (cfb9c57) to head (6c61c5e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   80.61%   80.63%   +0.01%     
==========================================
  Files          22       22              
  Lines        5169     5168       -1     
  Branches     5169     5168       -1     
==========================================
  Hits         4167     4167              
+ Misses        929      928       -1     
  Partials       73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 2256901 Nov 13, 2024
12 checks passed
@aborgna-q aborgna-q deleted the ab/is-node-convex branch November 13, 2024 11:46
@hugrbot hugrbot mentioned this pull request Nov 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@hugrbot
chore: release v0.12.3 (#142)
c91476b 
## 🤖 New release
* `portgraph`: 0.12.2 -> 0.12.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.12.3](v0.12.2...v0.12.3)
- 2024-11-13

### New Features

- Fastpath for `is_node_convex` on a single node
([#153](#153))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-q doug-q doug-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shortcircuit is_node_convex when there is exactly one node
2 participants
@aborgna-q @doug-q