fix: Intergraph edges in mermaid rendering #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 80.17% 80.55% +0.38%
==========================================
Files 22 22
Lines 5140 5174 +34
Branches 5140 5174 +34
==========================================
+ Hits 4121 4168 +47
+ Misses 946 933 -13
Partials 73 73 ☔ View full report in Codecov by Sentry. |
Defines intergraph edges on the parent region, so mermaid renders them correctly .
aborgna-q
force-pushed
the
ab/fix-mermaid-hierarchy
branch
from
e1519aa
to
1d358c3
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
## 🤖 New release * `portgraph`: 0.12.1 -> 0.12.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.12.2](v0.12.1...v0.12.2) - 2024-07-05 ### Bug Fixes - Intergraph edges in mermaid rendering ([#139](#139)) ### New Features - Add PortOffset::opposite ([#136](#136)) - Efficient LCA algorithm for the hierarchy ([#138](#138)) ### Testing - Use `insta` for mermaid/dot render tests ([#137](#137)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
github-merge-queue bot
pushed a commit
to CQCL/hugr
that referenced
this pull request
Jul 5, 2024
Includes the fix in CQCL/portgraph#139 that closes #1197
aborgna-q
added a commit
to CQCL/hugr
that referenced
this pull request
Jul 8, 2024
Includes the fix in CQCL/portgraph#139 that closes #1197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines intergraph edges on the parent region, so mermaid renders them correctly.
This required a lowest-common-ancestor implementation for the hierarchy. See #138.
I replaced the recursive DFS with a stack-based one that reuses the structures when exploring multiple trees.
I also added some benchmarks for both rendering algorithms.
This closes CQCL/hugr#1197