Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a DFS traversal for Hierarchy #145

Closed
aborgna-q opened this issue Aug 9, 2024 · 0 comments · Fixed by #162
Closed

Expose a DFS traversal for Hierarchy #145

aborgna-q opened this issue Aug 9, 2024 · 0 comments · Fixed by #162
Assignees
@aborgna-q
Labels
good first issue Good for newcomers

Comments

@aborgna-q
Copy link
Collaborator

The LCA implementation does a depth-first-search on hierarchies.
https://github.com/CQCL/portgraph/blob/main/src/algorithms/lca.rs

We should expose that in a standalone submodule.
@aborgna-q aborgna-q added the good first issue Good for newcomers label Aug 9, 2024
@aborgna-q aborgna-q mentioned this issue Nov 15, 2024
Merged
@aborgna-q aborgna-q linked a pull request Nov 15, 2024 that will close this issue
perf!: Manual impl of Region/FlatRegion for improved perf #162
Merged
@aborgna-q aborgna-q self-assigned this Nov 15, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 20, 2024
@aborgna-q
perf!: Manual impl of Region/FlatRegion for improved perf (#162)
0722b98 
Followup to #157. Avoids using `FilteredGraph` for the implementation of
`Region` and `FlatRegion` and instead implements the graph traits
manually to avoid doing full-graph traversals when we can do
better/faster checks.

Closes #159. Closes #145 (BFS rather than DFS). Closes #135.

BREAKING CHANGE: `Region` and `FlatRegion` are no longer aliases of
FilteredGraph
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf!: Manual impl of Region/FlatRegion for improved perf CQCL/portgraph
1 participant
@aborgna-q