refactor!: Replace SmolStr identifiers with wrapper types. #959

aborgna-q · 2024-04-22T09:37:45Z

Uses string_newtype to define TypeName, OpName, and ValueName types, to avoid using stringly-typed methods everywhere.
Also defines TypeNameSlice, OpNameSlice, ValueNameSlice. These that act like str to a String, or lke Path to a PathBuf; unsized slice types used through references.

Renames the OpName trait to NamedOp. Now NamedOp::name returns an OpName value.

Closes #834.

As an example of why this is useful, I caught some cases where ExtensionBuildError was being built with the wrong variant due to mixing up the different identifiers, since everything used SmolStr.

codecov · 2024-04-22T09:44:03Z

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 85.88%. Comparing base (fb76c7e) to head (ef8baea).

Files	Patch %	Lines
hugr/src/extension.rs	72.72%	3 Missing ⚠️
hugr/src/std_extensions/collections.rs	33.33%	2 Missing ⚠️
hugr/src/extension/declarative/signature.rs	50.00%	1 Missing ⚠️
hugr/src/extension/type_def.rs	0.00%	1 Missing ⚠️
hugr/src/ops/constant.rs	75.00%	1 Missing ⚠️
hugr/src/ops/custom.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   85.86%   85.88%   +0.01%     
==========================================
  Files          79       79              
  Lines       14441    14438       -3     
  Branches    14441    14438       -3     
==========================================
  Hits        12400    12400              
+ Misses       1404     1401       -3     
  Partials      637      637

Flag	Coverage Δ
rust	`85.88% <85.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ss2165

I like the results - especially catching those bugs in the errors. But it seems to be a lot of overhead - a whole other crate to depend on, and three new pub definitions per thing (including a marker type that will need to be hidden from docs). If there aren't any obvious simplifications to be made I guess we can go ahead.

aborgna-q · 2024-04-22T12:38:46Z

The new dependency is mostly for implementing all the required traits, it's a lot of boilerplate just to avoid having bounds on the Marker type. I could include that here, but it's a lot of stuff irrelevant to this crate.

We could drop the *Slice definitions and just use references to the owned types as parameters. It's less efficient, but may not make a big difference.
It may make some callsites more verbose though, as they'll require .clone()s.

aborgna-q · 2024-04-22T13:54:40Z

hugr/src/ops.rs

+/// Marker for the [`OpName`] wrapper.
+#[doc(hidden)]
+pub enum OpNameMarker {}
+
+/// A unique identifier for a operation.
+pub type OpName = string_newtype::SmolStrBuf<OpNameMarker>;
+
+/// Slice of a [`OpName`] operation identifier.
+pub type OpNameSlice = string_newtype::SmolStrRef<OpNameMarker>;
+


@doug-q Requesting a second opinion here. This looks a bit boilerplate-y/confusing, but it may reduce the amount of code on the callsites.

An alternative is to drop OpNameSlice and just use references to cloned OpNames for parameters.

I think OpNameRef is a better name, slicing being an uncommon operation on these types and so more distracting than helpful. One could also consider opnm in analogy with str, but with so many variants I think not.

I do think you want this type defined and used as args, rather than using &OpName, although I'm having difficulty justifying it. I think it's cool, but it's hard to see this making a difference.

I think callsites should use op_name.borrow() to obtain an &OpNameSlice no cloning should be required.

just use references to cloned OpNames for parameters.

Can you elaborate on where the cloning is necessary?

doug-q

Is there a reason you omit ExtensionId from your treatment?

doug-q · 2024-04-22T14:22:58Z

hugr/src/ops.rs

+/// Marker for the [`OpName`] wrapper.
+#[doc(hidden)]
+pub enum OpNameMarker {}
+
+/// A unique identifier for a operation.
+pub type OpName = string_newtype::SmolStrBuf<OpNameMarker>;
+
+/// Slice of a [`OpName`] operation identifier.
+pub type OpNameSlice = string_newtype::SmolStrRef<OpNameMarker>;
+


I think OpNameRef is a better name, slicing being an uncommon operation on these types and so more distracting than helpful. One could also consider opnm in analogy with str, but with so many variants I think not.

I do think you want this type defined and used as args, rather than using &OpName, although I'm having difficulty justifying it. I think it's cool, but it's hard to see this making a difference.

I think callsites should use op_name.borrow() to obtain an &OpNameSlice no cloning should be required.

doug-q · 2024-04-22T14:37:49Z

hugr/src/ops/constant.rs

@@ -426,7 +438,7 @@ mod test {
        ]));

        assert_eq!(v.const_type(), correct_type);
-        assert!(v.name().starts_with("const:function:"))
+        assert!(v.name().as_str().starts_with("const:function:"))


I'm surprised this as_str is required, I would expect a Deref chain to end up at &str

doug-q · 2024-04-22T14:43:29Z

I like the results - especially catching those bugs in the errors. But it seems to be a lot of overhead - a whole other crate to depend on, and three new pub definitions per thing (including a marker type that will need to be hidden from docs). If there aren't any obvious simplifications to be made I guess we can go ahead.

I agree this seems like a lot for a little benefit. Type aliases (i.e. type OpName = SmolStr) would make mistakes stick out to humans if not the compiler.

aborgna-q

I dropped the string-newtype dependency and changed the identifier to aliases of SmolStr.
The diff hasn't changed much aside from the identifier definitions.

aborgna-q · 2024-05-01T13:45:49Z

hugr/src/extension.rs

 trait CustomConcrete {
+    /// The identifier type for the concrete object.
+    type Identifier;


I left this associated type even though it always gets instantiated with SmolStr.

It doesn't change the way we use this trait but documents a bit better the behaviour.

ss2165

thanks for the changes 👍

## 🤖 New release * `hugr`: 0.3.1 -> 0.4.0-alpha.1 (⚠️ API breaking changes) ### ⚠️ `hugr` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum RegionBlocksError in /tmp/.tmpleGpag/hugr/hugr/src/algorithm/nest_cfgs.rs:282 enum EdgeValidationError in /tmp/.tmpleGpag/hugr/hugr/src/ops/validate.rs:213 enum ExtensionDeclarationError in /tmp/.tmpleGpag/hugr/hugr/src/extension/declarative.rs:179 enum InterGraphEdgeError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/validate.rs:748 enum ValidationError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/validate.rs:632 enum ValidationError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/validate.rs:632 enum HUGRSerializationError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/serialize.rs:107 enum InlineDFGError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/inline_dfg.rs:15 enum ExtensionError in /tmp/.tmpleGpag/hugr/hugr/src/extension/validate.rs:163 enum IntOpDef in /tmp/.tmpleGpag/hugr/hugr/src/std_extensions/arithmetic/int_ops.rs:51 enum ChildrenValidationError in /tmp/.tmpleGpag/hugr/hugr/src/ops/validate.rs:163 enum SumTypeError in /tmp/.tmpleGpag/hugr/hugr/src/types/check.rs:11 enum ReplaceError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/replace.rs:388 enum ConvertOpDef in /tmp/.tmpleGpag/hugr/hugr/src/std_extensions/arithmetic/conversions.rs:30 enum InvalidSubgraph in /tmp/.tmpleGpag/hugr/hugr/src/hugr/views/sibling_subgraph.rs:647 enum TypeArgError in /tmp/.tmpleGpag/hugr/hugr/src/types/type_param.rs:376 enum SumType in /tmp/.tmpleGpag/hugr/hugr/src/types.rs:124 enum ListOp in /tmp/.tmpleGpag/hugr/hugr/src/std_extensions/collections.rs:209 enum SimpleReplacementError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/simple_replace.rs:185 enum SimpleReplacementError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/simple_replace.rs:185 enum SimpleReplacementError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/simple_replace.rs:185 enum CustomCheckFailure in /tmp/.tmpleGpag/hugr/hugr/src/ops/constant.rs:227 enum CustomCheckFailure in /tmp/.tmpleGpag/hugr/hugr/src/ops/constant.rs:227 enum IdentityInsertionError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/insert_identity.rs:36 enum RemoveError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/consts.rs:18 enum OutlineCfgError in /tmp/.tmpleGpag/hugr/hugr/src/hugr/rewrite/outline_cfg.rs:223 enum NaryLogic in /tmp/.tmpleGpag/hugr/hugr/src/std_extensions/logic.rs:56 enum OpLoadError in /tmp/.tmpleGpag/hugr/hugr/src/extension/simple_op.rs:24 enum ConstTypeError in /tmp/.tmpleGpag/hugr/hugr/src/ops/constant.rs:244 enum ConstTypeError in /tmp/.tmpleGpag/hugr/hugr/src/ops/constant.rs:244 enum InvalidReplacement in /tmp/.tmpleGpag/hugr/hugr/src/hugr/views/sibling_subgraph.rs:629 enum InvalidSubgraphBoundary in /tmp/.tmpleGpag/hugr/hugr/src/hugr/views/sibling_subgraph.rs:665 enum InferExtensionError in /tmp/.tmpleGpag/hugr/hugr/src/extension/infer.rs:68 enum FloatOps in /tmp/.tmpleGpag/hugr/hugr/src/std_extensions/arithmetic/float_ops.rs:25 enum CustomOpError in /tmp/.tmpleGpag/hugr/hugr/src/ops/custom.rs:400 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/enum_missing.ron Failed in: enum hugr::ops::constant::Const, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:22 enum hugr::ops::Const, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:22 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/enum_struct_variant_field_added.ron Failed in: field dir of variant HUGRSerializationError::MissingPortOffset in /tmp/.tmpleGpag/hugr/hugr/src/hugr/serialize.rs:120 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/enum_variant_added.ron Failed in: variant SignatureError:LoadFunctionIncorrectlyAppliesType in /tmp/.tmpleGpag/hugr/hugr/src/extension.rs:182 variant ExtensionBuildError:ValueExists in /tmp/.tmpleGpag/hugr/hugr/src/extension.rs:405 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/inherent_method_missing.ron Failed in: ConvertOpDef::with_width, previously in file /tmp/.tmppKREXC/hugr/src/std_extensions/arithmetic/conversions.rs:78 IntOpDef::with_width, previously in file /tmp/.tmppKREXC/hugr/src/std_extensions/arithmetic/int_ops.rs:314 IntOpDef::with_two_widths, previously in file /tmp/.tmppKREXC/hugr/src/std_extensions/arithmetic/int_ops.rs:323 Const::const_type, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:124 Const::sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:138 Const::tuple, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:153 Const::function, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:164 Const::unit, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:173 Const::unit_sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:178 Const::unary_unit_sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:183 Const::true_val, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:188 Const::false_val, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:193 Const::from_bool, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:199 Const::extension, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:208 Const::get_custom_value, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:215 Const::const_type, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:124 Const::sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:138 Const::tuple, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:153 Const::function, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:164 Const::unit, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:173 Const::unit_sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:178 Const::unary_unit_sum, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:183 Const::true_val, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:188 Const::false_val, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:193 Const::from_bool, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:199 Const::extension, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:208 Const::get_custom_value, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:215 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/struct_missing.ron Failed in: struct hugr::std_extensions::arithmetic::int_types::ConstIntS, previously in file /tmp/.tmppKREXC/hugr/src/std_extensions/arithmetic/int_types.rs:83 struct hugr::std_extensions::arithmetic::int_types::ConstIntU, previously in file /tmp/.tmppKREXC/hugr/src/std_extensions/arithmetic/int_types.rs:76 struct hugr::ops::constant::ExtensionConst, previously in file /tmp/.tmppKREXC/hugr/src/ops/constant.rs:64 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/trait_missing.ron Failed in: trait hugr::ops::OpName, previously in file /tmp/.tmppKREXC/hugr/src/ops.rs:307 --- failure trait_removed_supertrait: supertrait removed or renamed --- Description: A supertrait was removed from a trait. Users of the trait can no longer assume it can also be used like its supertrait. ref: https://doc.rust-lang.org/reference/items/traits.html#supertraits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/trait_removed_supertrait.ron Failed in: supertrait hugr::ops::OpName of trait MakeExtensionOp in file /tmp/.tmpleGpag/hugr/hugr/src/extension/simple_op.rs:87 supertrait hugr::ops::OpName of trait MakeOpDef in file /tmp/.tmpleGpag/hugr/hugr/src/extension/simple_op.rs:45 ``` <details><summary>Changelog</summary> <blockquote> ## 0.4.0 (2024-05-13) ### Bug Fixes - Serialization round-trips ([#948](#948)) - [**breaking**] Combine `ConstIntU` and `ConstIntS` ([#974](#974)) - Disable serialisation tests when miri is active ([#977](#977)) - [**breaking**] Serialisation schema ([#968](#968)) - Correct constant fold for `fne`. ([#995](#995)) - [**breaking**] Serialisation fixes ([#997](#997)) - [**breaking**] OpDef serialisation ([#1013](#1013)) - NaryLogicOp constant folding ([#1026](#1026)) ### Features - 'Replace' rewrite returns node map ([#929](#929)) - `new` methods for leaf ops ([#940](#940)) - Add `string` type and `print` function to `prelude` ([#942](#942)) - `CustomOp::extension` utility function ([#951](#951)) - [**breaking**] Add `non_exhaustive` to various enums ([#952](#952)) - Encoder metadata in serialized hugr ([#955](#955)) - [**breaking**] Bring back Value ([#967](#967)) - Add LoadFunction node ([#947](#947)) - Add From impls for TypeArg ([#1002](#1002)) - Constant-folding of integer and logic operations ([#1009](#1009)) - [**breaking**] Update serialisation schema, implement `CustomConst` serialisation ([#1005](#1005)) - Merge basic blocks algorithm ([#956](#956)) - [**breaking**] Allow panic operation to have any input and output wires ([#1024](#1024)) ### Refactor - Outline hugr::serialize::test ([#976](#976)) - [**breaking**] Replace SmolStr identifiers with wrapper types. ([#959](#959)) - Separate extension validation from the rest ([#1011](#1011)) - Remove "trait TypeParametrised" ([#1019](#1019)) ### Testing - Add a test of instantiating an extension set ([#939](#939)) - Ignore serialisation tests when using miri ([#975](#975)) - [**breaking**] Test roundtrip serialisation against strict + lax schema ([#982](#982)) - Fix some bad assert_matches ([#1006](#1006)) - Expand test of instantiating extension sets ([#1003](#1003)) - Fix unconnected ports in extension test ([#1010](#1010)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Douglas Wilson <[email protected]>

## 🤖 New release * `hugr`: 0.3.1 -> 0.4.0 (⚠️ API breaking changes) ### ⚠️ `hugr` breaking changes ``` --- failure inherent_method_const_removed: pub method is no longer const --- Description: A publicly-visible method or associated fn is no longer `const` and can no longer be used in a `const` context. ref: https://doc.rust-lang.org/reference/const_eval.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/inherent_method_const_removed.ron Failed in: ConstF64::new in /tmp/.tmpwo5blB/hugr/hugr/src/std_extensions/arithmetic/float_types.rs:43 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/struct_missing.ron Failed in: struct hugr::ops::constant::ExtensionValue, previously in file /tmp/.tmpq1W6bC/hugr/src/ops/constant.rs:184 ``` <details><summary>Changelog</summary> <blockquote> ## 0.4.0 (2024-05-20) ### Bug Fixes - Disallow non-finite values for `ConstF64` ([#1075](#1075)) - Serialization round-trips ([#948](#948)) - [**breaking**] Combine `ConstIntU` and `ConstIntS` ([#974](#974)) - Disable serialisation tests when miri is active ([#977](#977)) - [**breaking**] Serialisation schema ([#968](#968)) - Correct constant fold for `fne`. ([#995](#995)) - [**breaking**] Serialisation fixes ([#997](#997)) - [**breaking**] OpDef serialisation ([#1013](#1013)) - NaryLogicOp constant folding ([#1026](#1026)) ### Features - Add verification to constant folding ([#1030](#1030)) - Add `Const::get_custom_value` ([#1037](#1037)) - Add serialization schema for metadata ([#1038](#1038)) - 'Replace' rewrite returns node map ([#929](#929)) - `new` methods for leaf ops ([#940](#940)) - Add `string` type and `print` function to `prelude` ([#942](#942)) - `CustomOp::extension` utility function ([#951](#951)) - [**breaking**] Add `non_exhaustive` to various enums ([#952](#952)) - Encoder metadata in serialized hugr ([#955](#955)) - [**breaking**] Bring back Value ([#967](#967)) - Add LoadFunction node ([#947](#947)) - Add From impls for TypeArg ([#1002](#1002)) - Constant-folding of integer and logic operations ([#1009](#1009)) - [**breaking**] Update serialisation schema, implement `CustomConst` serialisation ([#1005](#1005)) - Merge basic blocks algorithm ([#956](#956)) - [**breaking**] Allow panic operation to have any input and output wires ([#1024](#1024)) ### Refactor - [**breaking**] Rename `crate::ops::constant::ExtensionValue` => `OpaqueValue` ([#1036](#1036)) - Outline hugr::serialize::test ([#976](#976)) - [**breaking**] Replace SmolStr identifiers with wrapper types. ([#959](#959)) - Separate extension validation from the rest ([#1011](#1011)) - Remove "trait TypeParametrised" ([#1019](#1019)) ### Testing - Reorg OutlineCfg/nest_cfgs tests so hugr doesn't depend on algorithm ([#1007](#1007)) - Ignore tests which depend on typetag when cfg(miri) ([#1051](#1051)) - Really ignore tests which depend on typetag when cfg(miri) ([#1058](#1058)) - Proptests for round trip serialisation of `Type`s and `Op`s. ([#981](#981)) - Add a test of instantiating an extension set ([#939](#939)) - Ignore serialisation tests when using miri ([#975](#975)) - [**breaking**] Test roundtrip serialisation against strict + lax schema ([#982](#982)) - Fix some bad assert_matches ([#1006](#1006)) - Expand test of instantiating extension sets ([#1003](#1003)) - Fix unconnected ports in extension test ([#1010](#1010)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Douglas Wilson <[email protected]>

aborgna-q requested a review from ss2165 April 22, 2024 09:37

ss2165 reviewed Apr 22, 2024

View reviewed changes

aborgna-q requested a review from doug-q April 22, 2024 13:52

aborgna-q commented Apr 22, 2024

View reviewed changes

doug-q reviewed Apr 22, 2024

View reviewed changes

aborgna-q added 5 commits May 1, 2024 14:16

refactor: Add wrapers over smolStr for names

363dc04

feat: use string_newtype

ec6866d

#[doc(hidden)] for the marker types

8ce469e

Update string-newtype

c980dc3

Replace string-newtype with SmolStr aliases

e541538

aborgna-q force-pushed the feat/name-structs branch from fb80da4 to e541538 Compare May 1, 2024 13:25

aborgna-q added 2 commits May 1, 2024 14:36

Cleanup code now that everything is a &str

92a6007

Add doc to CustomConcrete::Identifier

ef8baea

aborgna-q commented May 1, 2024

View reviewed changes

aborgna-q requested a review from ss2165 May 1, 2024 13:46

ss2165 approved these changes May 1, 2024

View reviewed changes

aborgna-q added this pull request to the merge queue May 1, 2024

Merged via the queue into main with commit 187e33d May 1, 2024
17 checks passed

aborgna-q deleted the feat/name-structs branch May 1, 2024 16:42

github-actions bot mentioned this pull request May 1, 2024

chore: release v0.4.0-alpha.1 #964

Merged

doug-q mentioned this pull request May 20, 2024

chore: release v0.4.0 #1081

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: Replace SmolStr identifiers with wrapper types. #959

refactor!: Replace SmolStr identifiers with wrapper types. #959

aborgna-q commented Apr 22, 2024

codecov bot commented Apr 22, 2024 •

edited

Loading

ss2165 left a comment

aborgna-q commented Apr 22, 2024

aborgna-q Apr 22, 2024

doug-q Apr 22, 2024 •

edited

Loading

doug-q Apr 22, 2024

doug-q left a comment

doug-q Apr 22, 2024 •

edited

Loading

doug-q Apr 22, 2024

doug-q commented Apr 22, 2024 •

edited

Loading

aborgna-q left a comment

aborgna-q May 1, 2024

ss2165 left a comment

refactor!: Replace SmolStr identifiers with wrapper types. #959

refactor!: Replace SmolStr identifiers with wrapper types. #959

Conversation

aborgna-q commented Apr 22, 2024

codecov bot commented Apr 22, 2024 • edited Loading

Codecov Report

ss2165 left a comment

Choose a reason for hiding this comment

aborgna-q commented Apr 22, 2024

aborgna-q Apr 22, 2024

Choose a reason for hiding this comment

doug-q Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

doug-q Apr 22, 2024

Choose a reason for hiding this comment

doug-q left a comment

Choose a reason for hiding this comment

doug-q Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

doug-q Apr 22, 2024

Choose a reason for hiding this comment

doug-q commented Apr 22, 2024 • edited Loading

aborgna-q left a comment

Choose a reason for hiding this comment

aborgna-q May 1, 2024

Choose a reason for hiding this comment

ss2165 left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 22, 2024 •

edited

Loading

doug-q Apr 22, 2024 •

edited

Loading

doug-q Apr 22, 2024 •

edited

Loading

doug-q commented Apr 22, 2024 •

edited

Loading