Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Generalise extensions for add_op #618

Closed
wants to merge 1 commit into from

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Oct 23, 2023

No description provided.

Copy link
Contributor

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrgh all these different add_{node,op}{,_with_parent,_after,_before} methods and the different implementations of each are looking increasingly mazelike. Does or doesn't this affect add_op_with_parent?

@acl-cqc
Copy link
Contributor

acl-cqc commented Oct 31, 2023

Superceded by #622

@acl-cqc acl-cqc closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants