Code

feat: Provide+implement Replace API#613

Code

Merged

acl-cqc merged 75 commits intomainCQCL/hugr:mainfrom new/replaceCQCL/hugr:new/replaceCopy head branch name to clipboardNov 8, 2023

+906-6

Commits

Commits on Oct 16, 2023

• Add Replacement struct, NewEdgeSpec/NewEdgeKind, verify, invalidation_set

  acl-cqc

  committed
  2467729

• WIP Implement

  acl-cqc

  committed
  8e531d4

• Allow returning HugrError or Msg

  acl-cqc

  committed
  e9f4ba8

Commits on Oct 17, 2023

• Check edges

  acl-cqc

  committed
  886fba6

• Allow replacing edges from any node in S*; update spec

  acl-cqc

  committed
  ccf5200

• xxx_edges => mu_xxx (xxx = out, new, in -> inp)

  acl-cqc

  committed
  50abda1

Commits on Oct 18, 2023

• Make NewEdgeSpec+Replacement fields pub; run SimpleReplacement tests via applicator

  acl-cqc

  committed
  366209c

• fmt

  acl-cqc

  committed
  2b8c86f

• fix - new_node already in h, no need to translate

  acl-cqc

  committed
  de14f04

Commits on Oct 20, 2023

• Convert ReplaceError::Msg into cases

  acl-cqc

  committed
  a996f47

• clippy

  acl-cqc

  committed
  d78cbf2

• Rewrite incoming-edge check

  acl-cqc

  committed
  e6c3d8c

• Shorter 'descends'

  acl-cqc

  committed
  d70444e

• Check parent in apply

  acl-cqc

  committed
  6e94467

• insertion shouldn't fail?? Drop HugrError

  acl-cqc

  committed
  dcccde9

• v1 verify checks port kind

  acl-cqc

  committed
  7366aa7

• BadEdgeKind stores Direction (temp remove check on adding Order edges)

  acl-cqc

  committed
  46d2f48

• Break out check_existing_edge; transfer_edge does checks too

  acl-cqc

  committed
  1d15e72

• BadEdgeSpec: str -> Direction, Node -> Edge

  acl-cqc

  committed
  e371fc3

• apply fails w/BadEdgeSpec for replacement nodes

  acl-cqc

  committed
  16b52b4

• Note what checks required

  acl-cqc

  committed
  3701d50

• Factor out get_removed_nodes

  acl-cqc

  committed
  677692a

• transfer_edges: translation func returns Result<Node, WhichHugr>

  acl-cqc

  committed
  b2a7f00

• Use get_removed in apply

  acl-cqc

  committed
  86d6f39

• Add missing docs; move 'impl NewEdgeSpec' after struct def for Replacement

  acl-cqc

  committed
  4738710

• fixup! Use get_removed

  acl-cqc

  committed
  94f0586

• WIP test - failing in extension inference?!

  acl-cqc

  committed
  c4d5996

Commits on Oct 23, 2023

• Directly build Hugr rather than using Builder

  acl-cqc

  committed
  c23b798

Commits on Oct 24, 2023

• Fix initial Hugr building (using Lift!)

  acl-cqc

  committed
  476f0a3

• Fix root type of replacement, fmt

  acl-cqc

  committed
  52c7c54

• Fix: translate transfer-keys using node_map

  acl-cqc

  committed
  50b7b5c

• Check transfer keys too

  acl-cqc

  committed
  1bef633

• WIP debug

  acl-cqc

  committed
  72f9bf2

• Revert "WIP debug"

  Show description for be28f21
  acl-cqc

  committed
  be28f21

• Removal a list not a set, order matters

  acl-cqc

  committed
  3ae6d10

• Rename variables in test

  acl-cqc

  committed
  d41300a

• Update_validate, open_extensions, fix ports+wiring for predicate

  acl-cqc

  committed
  1c96bbd

Commits on Oct 25, 2023

• Merge commit 'origin/main^' into new/replace

  acl-cqc

  committed
  d383856

• Update renamed predicate->tuple/unit_sum

  acl-cqc

  committed
  5eaf13a

Commits on Oct 30, 2023

• Remove lift nodes, use open_extensions for Const + load-constant

  acl-cqc

  committed
  3fec96a

• CI fmt

  acl-cqc

  committed
  51164a0

Commits on Nov 2, 2023

• Merge remote-tracking branch 'origin/main' into HEAD

  acl-cqc

  committed
  5aeedb2

• Update re. port directions

  acl-cqc

  committed
  0ce6900

• CI fmt more

  acl-cqc

  committed
  002e89a

• Rewrite test using builder again; no lift nodes, Const has singleton-collections

  acl-cqc

  committed
  b35eb86

• clippy

  acl-cqc

  committed
  7a3029d

Commits on Nov 6, 2023

• Spec tweaks courtesy of Alec

  Show description for b463fd3
  

  acl-cqc

  and

  cqc-alec

  authored
  b463fd3

• Yes PartialEq, no Eq

  acl-cqc

  committed
  31a743d

• transfers->adoptions, fix doclinks, spec names

  acl-cqc

  committed
  8ace22b

• Note non-signature equality

  acl-cqc

  committed
  0014577

• WrongRootNodeTag: expected->removed, actual->replacement

  acl-cqc

  committed
  5436256

• Merge remote-tracking branch 'origin/main' into new/replace

  acl-cqc

  committed
  154b298

• no open_extensions

  acl-cqc

  committed
  da568ca

• TransfersNotSeparateDescendants is a general case of ConflictingTransfers

  acl-cqc

  committed
  f1c2114

• Assert about the Hugr

  acl-cqc

  committed
  a5cca09

Commits on Nov 7, 2023

• Start on test - build conditional Hugr

  acl-cqc

  committed
  961026f

• Test duplicate 'adoptions' rhs

  acl-cqc

  committed
  b8180d7

• Rename {case,r}_t/f to {case,r}1/2

  acl-cqc

  committed
  e5c426d

• Test wrong root node type

  acl-cqc

  committed
  326365f

• Functional style using ..r.clone(), test CantReplaceRoot

  acl-cqc

  committed
  2d6a7b6

• MultipleParents

  acl-cqc

  committed
  8b5ed23

• InvalidTransferTarget

  acl-cqc

  committed
  71786a9

• Invalid(TransferTarget=>AdoptingParent), (Transfers=>Adoptees)NotSeparateDescendants, doclinks

  acl-cqc

  committed
  65abd61

• Comments, one BadEdgeSpec

  acl-cqc

  committed
  804a005

• Another BadEdgeSpec test

  acl-cqc

  committed
  ed440b6

• NotSeparateDescendants - comment nodes are best-effort

  acl-cqc

  committed
  c502018

• BadEdgeKind

  acl-cqc

  committed
  b1dbfc4

• Run tests on both verify + apply, include one on mu_new

  acl-cqc

  committed
  fcf8827

• WIP test NoRemovedEdge...failing

  acl-cqc

  committed
  eb3c519

• Fix for both

  acl-cqc

  committed
  17b1618

• refactor: move descends_any inside check_existing_edge

  acl-cqc

  committed
  8788dc7

• Merge remote-tracking branch 'origin/main' into new/replace

  acl-cqc

  committed
  aba2f41

• Generalize Container::add_constant, pass None

  acl-cqc

  committed
  1b39df7

Commits on Nov 8, 2023

• Merge 'origin/main' into new/replace, update add_{op=>node}_...

  acl-cqc

  committed
  ce9311a

• Simplify invalidation_set

  acl-cqc

  committed
  bbb172d