-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add extension deltas to CFG ops #503
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
use smol_str::SmolStr; | ||
|
||
use crate::extension::ExtensionSet; | ||
use crate::type_row; | ||
use crate::types::{EdgeKind, FunctionType, Type, TypeRow}; | ||
|
||
use super::dataflow::DataflowOpTrait; | ||
|
@@ -97,6 +98,7 @@ impl Conditional { | |
pub struct CFG { | ||
pub inputs: TypeRow, | ||
pub outputs: TypeRow, | ||
pub extension_delta: ExtensionSet, | ||
} | ||
|
||
impl_op_name!(CFG); | ||
|
@@ -110,6 +112,7 @@ impl DataflowOpTrait for CFG { | |
|
||
fn signature(&self) -> FunctionType { | ||
FunctionType::new(self.inputs.clone(), self.outputs.clone()) | ||
.with_extension_delta(&self.extension_delta) | ||
} | ||
} | ||
|
||
|
@@ -123,6 +126,7 @@ pub enum BasicBlock { | |
inputs: TypeRow, | ||
other_outputs: TypeRow, | ||
predicate_variants: Vec<TypeRow>, | ||
extension_delta: ExtensionSet, | ||
}, | ||
/// The single exit node of the CFG, has no children, | ||
/// stores the types of the CFG node output. | ||
|
@@ -166,6 +170,15 @@ impl OpTrait for BasicBlock { | |
fn other_output(&self) -> Option<EdgeKind> { | ||
Some(EdgeKind::ControlFlow) | ||
} | ||
|
||
fn signature(&self) -> FunctionType { | ||
match self { | ||
BasicBlock::DFB { | ||
extension_delta, .. | ||
} => FunctionType::new(type_row![], type_row![]).with_extension_delta(extension_delta), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a hack to make extension inference work! Previously the signature was just the empty default |
||
BasicBlock::Exit { .. } => FunctionType::new(type_row![], type_row![]), | ||
} | ||
} | ||
} | ||
|
||
impl BasicBlock { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do another PR to make these methods take
FunctionType
as an argument and taking theextension_delta
from there