Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add StringVal to hugr-py #1818

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: Add StringVal to hugr-py #1818

merged 1 commit into from
Dec 19, 2024

Conversation

tatiana-s
Copy link
Contributor

Closes #1817

Enables strings in Guppy, see CQCL/guppylang#695

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.64%. Comparing base (1f841ae) to head (15a20d1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-py/src/hugr/std/prelude.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1818   +/-   ##
=======================================
  Coverage   86.63%   86.64%           
=======================================
  Files         191      192    +1     
  Lines       34738    34754   +16     
  Branches    31571    31571           
=======================================
+ Hits        30097    30112   +15     
- Misses       2940     2941    +1     
  Partials     1701     1701           
Flag Coverage Δ
python 92.42% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana-s tatiana-s marked this pull request as ready for review December 19, 2024 10:09
@tatiana-s tatiana-s requested a review from a team as a code owner December 19, 2024 10:09
@tatiana-s tatiana-s requested a review from mark-koch December 19, 2024 10:09
Copy link
Contributor

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tatiana-s tatiana-s added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit b05a419 Dec 19, 2024
23 checks passed
@tatiana-s tatiana-s deleted the ts/string-val branch December 19, 2024 11:35
github-merge-queue bot pushed a commit that referenced this pull request Dec 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.10.2](hugr-py-v0.10.1...hugr-py-v0.10.2)
(2024-12-20)


### Features

* Add `StringVal` to hugr-py
([#1818](#1818))
([b05a419](b05a419))


### Bug Fixes

* **py:** Fix array/list value serialization
([#1827](#1827))
([7bf85b9](7bf85b9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Seyon Sivarajah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose a value based on ConstString
2 participants