feat(hugr-py): move std extension types/ops in to std module
#1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested review from
zrho and
aborgna-q
and removed request for
a team and
zrho
aborgna-q
approved these changes
Jul 9, 2024
hugr-py/src/hugr/std/int.py
Outdated
| extension: tys.ExtensionId = "arithmetic.int" | ||
|
|
||
|
|
||
| _ARG_5 = tys.BoundedNatArg(n=5) |
There was a problem hiding this comment.
nit: Call this _ARG_I32? It's a bit more legible
Not complete, see #1287 Quantum operations left in tests as they are not part of std extensions set (maybe they should be...?)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
+ Coverage 87.04% 87.07% +0.02%
==========================================
Files 103 106 +3
Lines 19243 19295 +52
Branches 17073 17073
==========================================
+ Hits 16750 16801 +51
- Misses 1716 1717 +1
Partials 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.0](hugr-py-v0.3.1...hugr-py-v0.4.0) (2024-07-10) ### ⚠ BREAKING CHANGES * **hugr-py:** dataclasses that derive from `ops.Custom` now have to be frozen, and instances cannot be mutated. ### Features * **hugr-py:** `ops.Custom` is now a frozen dataclass ([94702d2](94702d2)) * **hugr-py:** move std extension types/ops in to `std` module ([#1288](#1288)) ([7d82245](7d82245)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not complete, see #1287
Quantum operations left in tests as they are not part of std extensions set (maybe they should be...?)