refactor(hugr-py): freeze custom ops #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes singletons like `Measure = MeasureDef()` safer, as the instance isn't going to get mutated between uses
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 103 103
Lines 19344 19344
Branches 17174 17174
=======================================
Hits 16851 16851
Misses 1715 1715
Partials 778 778
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
doug-q
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(hugr-py)!:
ops.Customis now a frozen dataclassMakes singletons like
Measure = MeasureDef()safer, as the instance isn't going to get mutated between usesBREAKING CHANGE: dataclasses that derive from
ops.Customnow have to be frozen, and instances cannot be mutated.END_COMMIT_OVERRIDE