Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/FYI: Subset constraints #1137

Closed
wants to merge 5 commits into from
Closed

WIP/FYI: Subset constraints #1137

wants to merge 5 commits into from

Conversation

acl-cqc
Copy link
Contributor

@acl-cqc acl-cqc commented May 30, 2024

Around 20 tests failing; some probably need updating, but there are probably still some bugs yet. (Also some internal/unit tests of the inference algorithm that don't compile now, which I've commented out.) However I hope this includes basically the new code that we need, with only "tidying" and bugfixing still to come.

And, of course, there is Lukas' suggestion, maybe we don't need input_extensions (or an algorithm to compute them) at all...

@hugrbot
Copy link
Collaborator

hugrbot commented May 30, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

No release type found in pull request title "WIP/FYI: Subset constraints". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

@acl-cqc acl-cqc force-pushed the feat/subset_constraints branch from 3d2bcff to 3c7b1c2 Compare May 30, 2024 08:07
@acl-cqc
Copy link
Contributor Author

acl-cqc commented Jun 7, 2024

Think we are going for #1142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants