Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin nightly rust version #1124

Merged
merged 8 commits into from
May 29, 2024
Merged

ci: Pin nightly rust version #1124

merged 8 commits into from
May 29, 2024

Conversation

aborgna-q
Copy link
Collaborator

Nightly rust tests are failing, seemingly due to rust-lang/rust#125474.

This PR fixes the toolchain to the last working nightly until the problem is resolved.

CI fail: https://github.com/CQCL/hugr/actions/runs/9281876942/job/25538729650#step:6:856

@aborgna-q aborgna-q requested a review from cqc-alec May 29, 2024 09:09
@aborgna-q aborgna-q requested a review from a team as a code owner May 29, 2024 09:09
@aborgna-q
Copy link
Collaborator Author

Uhm, the ci-rs workflow is not getting triggered...

@aborgna-q
Copy link
Collaborator Author

I had replaced the uses: dtolnay/rust-toolchain@nightly line with uses: dtolnay/rust-toolchain and an explicit parameter for the nightly version,
but it seems that missing the branch name when specifying the action causes the workflow to silently fail (and not get triggered).

u.u

The fix was to add a @master prefix.

@aborgna-q aborgna-q added this pull request to the merge queue May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (f757cc8) to head (cbf6766).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   86.78%   86.77%   -0.01%     
==========================================
  Files          90       90              
  Lines       18546    18549       +3     
  Branches    18153    18156       +3     
==========================================
+ Hits        16095    16096       +1     
  Misses       1606     1606              
- Partials      845      847       +2     
Flag Coverage Δ
rust 86.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit c74e124 May 29, 2024
18 checks passed
@aborgna-q aborgna-q deleted the ab/pin-nightly branch May 29, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants