Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hugr binary cli tool #1096

Merged
merged 4 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions hugr/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ path = "src/lib.rs"

[features]
extension_inference = []
cli = ["dep:clap", "dep:clap-stdin"]

[dependencies]
portgraph = { workspace = true, features = ["serde", "petgraph"] }
Expand Down Expand Up @@ -52,6 +53,8 @@ delegate = "0.12.0"
paste = "1.0"
strum = "0.26.1"
strum_macros = "0.26.1"
clap = { version = "4.5.4", features = ["derive"], optional = true }
clap-stdin = { version = "0.4.0", optional = true }

[dev-dependencies]
criterion = { version = "0.5.1", features = ["html_reports"] }
Expand All @@ -61,10 +64,18 @@ urlencoding = "2.1.2"
cool_asserts = "2.0.3"
insta = { workspace = true, features = ["yaml"] }
jsonschema = "0.18.0"
proptest = { version = "1.4.0" }
proptest-derive = { version = "0.4.0"}
regex-syntax = { version = "0.8.3"}
proptest = { version = "1.4.0" }
proptest-derive = { version = "0.4.0" }
regex-syntax = { version = "0.8.3" }
assert_cmd = "2.0.14"
predicates = "3.1.0"
assert_fs = "1.1.1"

[[bench]]
name = "bench_main"
harness = false


[[bin]]
name = "hugr"
required-features = ["cli"]
41 changes: 41 additions & 0 deletions hugr/src/cli.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
//! Standard command line tools, used by the hugr binary.

use clap::Parser;
use clap_stdin::FileOrStdin;

use crate::{extension::ExtensionRegistry, Hugr, HugrView};
/// Validate and visualise a HUGR file.
#[derive(Parser, Debug)]
#[clap(version = "1.0", long_about = None)]
#[clap(about = "Validate a HUGR.")]
struct CmdLineArgs {
input: FileOrStdin,
/// Visualise with mermaid.
#[arg(short, long, value_name = "MERMAID", help = "Visualise with mermaid.")]
mermaid: bool,

/// Skip validation.
#[arg(short, long, help = "Skip validation.")]
no_validate: bool,
// TODO YAML extensions
}

/// String to print when validation is successful.
pub const VALID_PRINT: &str = "HUGR valid!";

/// Run the HUGR cli and validate against an extension registry.
pub fn run(registry: &ExtensionRegistry) -> Result<(), Box<dyn std::error::Error>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to expose pub CmdLineArgs and either take it as a parameter here, or put this function on impl CmdLineArgs.

This moves the CmdLineArgs::parse() into the caller, which allows callers to add (and handle) options, embed as a SubCommand etc.

let opts = CmdLineArgs::parse();

let mut hugr: Hugr = serde_json::from_reader(opts.input.into_reader()?)?;
if opts.mermaid {
println!("{}", hugr.mermaid_string());
}

if !opts.no_validate {
hugr.update_validate(registry)?;

println!("{}", VALID_PRINT);
}
Ok(())
}
3 changes: 3 additions & 0 deletions hugr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,8 @@ pub use crate::core::{
pub use crate::extension::Extension;
pub use crate::hugr::{Hugr, HugrView, SimpleReplacement};

#[cfg(feature = "cli")]
pub mod cli;

#[cfg(test)]
pub mod proptest;
28 changes: 28 additions & 0 deletions hugr/src/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
//! Validate serialized HUGR on the command line

use hugr::std_extensions::arithmetic::{
conversions::EXTENSION as CONVERSIONS_EXTENSION, float_ops::EXTENSION as FLOAT_OPS_EXTENSION,
float_types::EXTENSION as FLOAT_TYPES_EXTENSION, int_ops::EXTENSION as INT_OPS_EXTENSION,
int_types::EXTENSION as INT_TYPES_EXTENSION,
};
use hugr::std_extensions::logic::EXTENSION as LOGICS_EXTENSION;

use hugr::extension::{ExtensionRegistry, PRELUDE};

use hugr::cli::run;

fn main() -> Result<(), Box<dyn std::error::Error>> {
// validate with all std extensions
let reg = ExtensionRegistry::try_new([
PRELUDE.to_owned(),
INT_OPS_EXTENSION.to_owned(),
INT_TYPES_EXTENSION.to_owned(),
CONVERSIONS_EXTENSION.to_owned(),
FLOAT_OPS_EXTENSION.to_owned(),
FLOAT_TYPES_EXTENSION.to_owned(),
LOGICS_EXTENSION.to_owned(),
])
.unwrap();

run(&reg)
}
95 changes: 95 additions & 0 deletions hugr/tests/cli.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
#![cfg(feature = "cli")]

use assert_cmd::Command;
use assert_fs::{fixture::FileWriteStr, NamedTempFile};
use hugr::{
builder::{Dataflow, DataflowHugr},
extension::prelude::BOOL_T,
type_row,
types::FunctionType,
Hugr,
};
use predicates::prelude::*;
use rstest::{fixture, rstest};

use hugr::cli::VALID_PRINT;
#[fixture]
fn cmd() -> Command {
Command::cargo_bin(env!("CARGO_PKG_NAME")).unwrap()
}

#[fixture]
fn test_hugr() -> Hugr {
use hugr::builder::DFGBuilder;

let df = DFGBuilder::new(FunctionType::new_endo(type_row![BOOL_T])).unwrap();
let [i] = df.input_wires_arr();
df.finish_prelude_hugr_with_outputs([i]).unwrap()
}

#[fixture]
fn test_hugr_string(test_hugr: Hugr) -> String {
serde_json::to_string(&test_hugr).unwrap()
}

#[fixture]
fn test_hugr_file(test_hugr_string: String) -> NamedTempFile {
// TODO use proptests?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For generating the Hugr? That's a long way off, we need to generate valid sub-properties then wire them together into a Hugr. I don't think it would be useful here, we are already testing serialisation elsewhere.

let file = assert_fs::NamedTempFile::new("sample.hugr").unwrap();
file.write_str(&test_hugr_string).unwrap();
file
}

#[rstest]
fn test_doesnt_exist(mut cmd: Command) -> Result<(), Box<dyn std::error::Error>> {
cmd.arg("foobar");
cmd.assert()
.failure()
.stderr(predicate::str::contains("No such file or directory"));

Ok(())
}

#[rstest]
fn test_validate(
test_hugr_file: NamedTempFile,
mut cmd: Command,
) -> Result<(), Box<dyn std::error::Error>> {
cmd.arg(test_hugr_file.path());
cmd.assert()
.success()
.stdout(predicate::str::contains(VALID_PRINT));

Ok(())
}

#[rstest]
fn test_stdin(
test_hugr_string: String,
mut cmd: Command,
) -> Result<(), Box<dyn std::error::Error>> {
cmd.write_stdin(test_hugr_string);
cmd.arg("-");

cmd.assert()
.success()
.stdout(predicate::str::contains(VALID_PRINT));

Ok(())
}

#[rstest]
fn test_mermaid(
test_hugr_file: NamedTempFile,
mut cmd: Command,
) -> Result<(), Box<dyn std::error::Error>> {
const MERMAID: &str = "graph LR\n subgraph 0 [\"(0) DFG\"]";
cmd.arg(test_hugr_file.path());
cmd.arg("--mermaid");
cmd.arg("--no-validate");
cmd.assert()
.success()
.stdout(predicate::str::contains(MERMAID));

Ok(())
}