You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we add extension parameters to extension inference, as in #713, we may run into the situation where the type variables don't actually make sense, causing inference to fail with an opaque error message. We check that type variables make sense during validation, but currently this happens after extension inference.
Proposed solution:
Separate extension validation from the rest of validation
Run general validation before extension inference is run
Then, run the extension validation
Down the line, we can think about merging extension inference with validation
Downside: This means traversing the graph for validation twice rather than just once
The text was updated successfully, but these errors were encountered:
A further refactor to validation. Note that the CI will fail without
#1010 because this change raises the hugr validity errors before the
extension errors. This seems like the win #943 is meant to give us 😁
Resolves#943
Problem:
When we add extension parameters to extension inference, as in #713, we may run into the situation where the type variables don't actually make sense, causing inference to fail with an opaque error message. We check that type variables make sense during validation, but currently this happens after extension inference.
Proposed solution:
Downside: This means traversing the graph for validation twice rather than just once
The text was updated successfully, but these errors were encountered: