feature flag for extension inference and validation #784
Assignees
Milestone
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2024
Add a feature flag "extension_inference", without which `Hugr::infer_extensions` is replaced by a dummy method, and `ValidationContext` doesn't use a `ExtensionValidator`, and tests that require extension inference to be done are disabled. Our CI runs tests and benchmarks once with default features, then again with all features, so extension inference is still being tested by CI. The workflow has only been altered to tell `clippy` to run with all features as well. Resolves #784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extension inference and validation are not complete - there is work yet to do to be able to infer lift nodes (if we need them at all) and to avoid annotations in DFG etc. see #426. For release 0.1 just put the inference and validation behind an experimental feature flag (and record that in the readme - that it doesn't work). CI need not test with this flag on. Existing tests should pass, and new tests can be written more simply that won't pass if the flag is turned on.
The text was updated successfully, but these errors were encountered: